Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update decoration order and environment parsing fixes #65

Merged
merged 26 commits into from
Jan 24, 2019
Merged

Conversation

bannanc
Copy link
Member

@bannanc bannanc commented Jan 18, 2019

This PR is addressing issue #62 currently, but I'm going to take a look at LGTM and travis to see if I can address issues #61 and #64 also.

I need to see what is causing the tests to fail also.

@bannanc bannanc added the WIP This PR (or issue) is still a work in progress label Jan 18, 2019
@bannanc bannanc added the Review This is waiting for a reviewer label Jan 18, 2019
@bannanc bannanc removed the Review This is waiting for a reviewer label Jan 18, 2019
@codecov
Copy link

codecov bot commented Jan 18, 2019

Codecov Report

Merging #65 into master will decrease coverage by 0.4%.
The diff coverage is 66.08%.

@bannanc
Copy link
Member Author

bannanc commented Jan 18, 2019

This pull request fixes 7 alerts when merging a5be002 into 3c65104 - view on LGTM.com

fixed alerts:

  • 2 for Except block handles 'BaseException'
  • 2 for Unused import
  • 2 for Redundant assignment
  • 1 for Testing equality to None

Comment posted by LGTM.com

@bannanc
Copy link
Member Author

bannanc commented Jan 19, 2019

This pull request introduces 5 alerts and fixes 26 when merging f040c25 into 3c65104 - view on LGTM.com

new alerts:

  • 4 for __eq__ not overridden when adding attributes
  • 1 for Comparison of identical values

fixed alerts:

  • 7 for Testing equality to None
  • 5 for Incomplete ordering
  • 4 for Except block handles 'BaseException'
  • 4 for Unused import
  • 2 for Module is imported with 'import' and 'import from'
  • 2 for Redundant assignment
  • 1 for Unused local variable
  • 1 for Inconsistent equality and hashing

Comment posted by LGTM.com

@bannanc
Copy link
Member Author

bannanc commented Jan 19, 2019

When trying to fix lgtm I broke a few things and apparently added alerts so there's still a lot of work to do, it is not ready for review.

@bannanc
Copy link
Member Author

bannanc commented Jan 23, 2019

This pull request introduces 5 alerts and fixes 26 when merging a1ebce2 into 3c65104 - view on LGTM.com

new alerts:

  • 4 for __eq__ not overridden when adding attributes
  • 1 for Comparison of identical values

fixed alerts:

  • 7 for Testing equality to None
  • 5 for Incomplete ordering
  • 4 for Except block handles 'BaseException'
  • 4 for Unused import
  • 2 for Module is imported with 'import' and 'import from'
  • 2 for Redundant assignment
  • 1 for Unused local variable
  • 1 for Inconsistent equality and hashing

Comment posted by LGTM.com

@bannanc
Copy link
Member Author

bannanc commented Jan 23, 2019

This pull request introduces 5 alerts and fixes 26 when merging aa55d6e into 3c65104 - view on LGTM.com

new alerts:

  • 4 for __eq__ not overridden when adding attributes
  • 1 for Comparison of identical values

fixed alerts:

  • 7 for Testing equality to None
  • 5 for Incomplete ordering
  • 4 for Except block handles 'BaseException'
  • 4 for Unused import
  • 2 for Module is imported with 'import' and 'import from'
  • 2 for Redundant assignment
  • 1 for Unused local variable
  • 1 for Inconsistent equality and hashing

Comment posted by LGTM.com

@bannanc
Copy link
Member Author

bannanc commented Jan 24, 2019

This pull request introduces 5 alerts and fixes 26 when merging 86a5a07 into 3c65104 - view on LGTM.com

new alerts:

  • 4 for __eq__ not overridden when adding attributes
  • 1 for Comparison of identical values

fixed alerts:

  • 7 for Testing equality to None
  • 5 for Incomplete ordering
  • 4 for Except block handles 'BaseException'
  • 4 for Unused import
  • 2 for Module is imported with 'import' and 'import from'
  • 2 for Redundant assignment
  • 1 for Unused local variable
  • 1 for Inconsistent equality and hashing

Comment posted by LGTM.com

@bannanc bannanc mentioned this pull request Jan 24, 2019
@bannanc
Copy link
Member Author

bannanc commented Jan 24, 2019

This pull request introduces 2 alerts and fixes 26 when merging 8d9bce0 into 3c65104 - view on LGTM.com

new alerts:

  • 2 for __eq__ not overridden when adding attributes

fixed alerts:

  • 7 for Testing equality to None
  • 5 for Incomplete ordering
  • 4 for Except block handles 'BaseException'
  • 4 for Unused import
  • 2 for Module is imported with 'import' and 'import from'
  • 2 for Redundant assignment
  • 1 for Unused local variable
  • 1 for Inconsistent equality and hashing

Comment posted by LGTM.com

@bannanc bannanc changed the title Exploring decoration order fixes Update decoration order and environment parsion fixes Jan 24, 2019
@bannanc bannanc changed the title Update decoration order and environment parsion fixes Update decoration order and environment parsing fixes Jan 24, 2019
@bannanc bannanc added Review This is waiting for a reviewer and removed WIP This PR (or issue) is still a work in progress labels Jan 24, 2019
@bannanc
Copy link
Member Author

bannanc commented Jan 24, 2019

@jmaat I'm going to merge this one too, I know it would be better for you to review first, but I want to get a version out before I leave this weekend and the order and parsing errors shouldn't be in that. Could you make sure this is on your list to check?

@bannanc bannanc merged commit f4776ba into master Jan 24, 2019
@bannanc bannanc deleted the dec_order branch April 18, 2019 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review This is waiting for a reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant