Switch from fmtlib to std::format. #143
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from
fmtlib
tostd::format
.I already updated the modorganizer project to follow these changes, PR to come, but other repositories probably needs to be updated as well.
Some details:
std::formatter
- There is a specialization to allow usingstd::basic_string
of any char-type with any format string (e.g.,std::format("{}", L"Hello World!"
). This was done to follow the previous converter behavior, not sure if we want to keep it.std::format_string
- This allows for compile-time checking of the format string. In an ideal world, that would be the sole overload, but we have many places with translated format string. I kept the templatedF
version, but this could probably be replaced with aQStringView
/QString
overload.Note: This supersedes #142