PluginList::refresh speedup #2046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Holt59
requested changes
Jun 10, 2024
Holt59
approved these changes
Jun 10, 2024
AnyOldName3
reviewed
Jun 10, 2024
| if (current.get() == nullptr) { | ||
| continue; | ||
| } | ||
| QString filename = ToQString(current->getName()); | ||
| const QString& filename = ToQString(current->getName()); |
There was a problem hiding this comment.
It's not important, but for future reference, the change to this line does nothing. ToQString returns a QString, not a const QString&, so a QString has to be constructed in this stack frame anyway. There's no copy happening in the old or new version due to copy elision.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should decrease the time it takes to refresh the plugin list, particularly for Fallout 4 and Starfield instances where the loadOrderMechanism call is costly.
I tested by enabling/disabling an empty mod in a Fallout 4 instance containing about 2000 dummy ESMs and ESPs. The loadOrderMechanism change saw the average time decrease from 2900ms to 710ms. The other changes further reduced that to 210ms.