MODE-1526, MODE-1512 #420
Merged
MODE-1526, MODE-1512 #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the repository is shutdown, we're not closing the Hibernate Search SearchFactoryImplementor. This doesn't appear to remove the index's (native) write lock; will have to consult the Hibernate Search experts for assistance.
The DocumentExternalizer was checking the number of bytes available for reading without blocking, and this seemed to always return 0 bytes. The DocumentExternalizer was then immediately returning without actually reading any of the content; obviously this was wrong. Now, with some minor changes to the BSON reader/writer, the DocumentExternalizer is merely always just reading the BSON document. This appears to have fixed the persistence issue, and the recently-added unit test now runs (after some modifications). Note that we're still apparently having issues with the index (native) write locks being kept after shutdown; this will be worked under MODE-1512.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DocumentExternalizer was checking the number of bytes available for reading without blocking, and this seemed to always return 0 bytes. The DocumentExternalizer was then immediately returning without actually reading any of the content; obviously this was wrong. Now, with some minor changes to the BSON reader/writer, the DocumentExternalizer is merely always just reading the BSON document.
This appears to have fixed the persistence issue, and the recently-added unit test now runs (after some modifications). Note that we're still apparently having issues with the index (native) write locks being kept after shutdown; this will be worked under MODE-1512.
Finally, hen the repository is shutdown, we're not closing the Hibernate Search SearchFactoryImplementor. This doesn't appear to remove the index's (native) write lock; will have to consult the Hibernate Search experts for assistance.