Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve style checks and test them on travis #204

Merged
merged 14 commits into from
Sep 5, 2019
Merged

Improve style checks and test them on travis #204

merged 14 commits into from
Sep 5, 2019

Conversation

jonc125
Copy link
Contributor

@jonc125 jonc125 commented Aug 14, 2019

I've not fixed issues in the datasets app because there's no point until #193 is merged. This PR should then be updated and any remaining style issues fixed.

ModellingWebLab/project_issues#43

@jonc125 jonc125 mentioned this pull request Aug 21, 2019
9 tasks
@codecov-io
Copy link

Codecov Report

Merging #204 into master will decrease coverage by <.1%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #204     +/-   ##
=======================================
- Coverage    95.1%    95%   -0.1%     
=======================================
  Files          60     60             
  Lines        2533   2506     -27     
  Branches      268    268             
=======================================
- Hits         2409   2382     -27     
  Misses         88     88             
  Partials       36     36
Impacted Files Coverage Δ
weblab/datasets/templatetags/datasets.py 81.8% <ø> (ø) ⬆️
weblab/datasets/forms.py 92.3% <ø> (-0.8%) ⬇️
weblab/core/models.py 100% <ø> (ø) ⬆️
weblab/experiments/urls.py 100% <ø> (ø) ⬆️
weblab/conftest.py 99.3% <100%> (ø) ⬆️
weblab/experiments/views.py 97.5% <100%> (ø) ⬆️
weblab/entities/forms.py 95.3% <100%> (ø) ⬆️
weblab/entities/repository.py 98.7% <100%> (ø) ⬆️
weblab/experiments/models.py 99% <100%> (ø) ⬆️
weblab/datasets/views.py 92.1% <100%> (-1.2%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdf5bbc...67dccc6. Read the comment docs.

@jonc125 jonc125 self-assigned this Aug 21, 2019
@jonc125
Copy link
Contributor Author

jonc125 commented Aug 21, 2019

@d20gdx this should be relatively straightforward to review - it's just adding the style check config and then fixing all the issues it threw up. Do ask if anything is unclear!

setup.cfg Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
@jonc125 jonc125 merged commit ce9f2dd into master Sep 5, 2019
@jonc125 jonc125 deleted the style-checks branch September 5, 2019 15:34
MauriceHendrix pushed a commit that referenced this pull request Jul 22, 2021
Improve style checks and test them on travis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants