Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve travis testing #66

Merged
merged 10 commits into from
Aug 19, 2019
Merged

Improve travis testing #66

merged 10 commits into from
Aug 19, 2019

Conversation

jonc125
Copy link
Contributor

@jonc125 jonc125 commented Aug 16, 2019

  • Check with both pinned packages and setup.py install
  • Use consistent flake8 & isort checks
  • Add code coverage

Fixes #41, fixes #42.

@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@b54edd5). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #66   +/-   ##
==========================================
  Coverage           ?   87.29%           
==========================================
  Files              ?        8           
  Lines              ?      842           
  Branches           ?      181           
==========================================
  Hits               ?      735           
  Misses             ?       70           
  Partials           ?       37
Impacted Files Coverage Δ
cellmlmanip/units.py 81.65% <ø> (ø)
cellmlmanip/__init__.py 100% <100%> (ø)
cellmlmanip/mathml2sympy/__init__.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b54edd5...dff05be. Read the comment docs.

Before it only worked with cellmlmanip installed using `-e`.
I don't understand why :(
Copy link
Contributor

@MichaelClerx MichaelClerx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments / questions!

.travis.yml Show resolved Hide resolved
.travis.yml Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
cellmlmanip/.coveragerc Outdated Show resolved Hide resolved
cellmlmanip/.coveragerc Outdated Show resolved Hide resolved
setup.cfg Show resolved Hide resolved
setup.cfg Show resolved Hide resolved
@MichaelClerx MichaelClerx merged commit 1df7052 into develop Aug 19, 2019
@MichaelClerx MichaelClerx deleted the defrost-testing branch August 19, 2019 11:51
@MichaelClerx MichaelClerx restored the defrost-testing branch August 19, 2019 11:51
@MichaelClerx MichaelClerx deleted the defrost-testing branch August 19, 2019 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add flake8 testing to travis Add coverage testing
2 participants