h5hist: write overflow as boolean but still support string #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
=======================================
Coverage 83.60% 83.60%
=======================================
Files 10 10
Lines 787 787
=======================================
Hits 658 658
Misses 129 129 ☔ View full report in Codecov by Sentry. |
|
I think nobody is using it you can just override it for now |
|
OK done ;) |
Moelf
reviewed
Dec 19, 2023
Moelf
approved these changes
Dec 20, 2023
|
you wanna do a release on this? |
|
Initially I thought this will simply go into 0.11 but I guess that will take a few more days. I'll do a quick release now... |
|
since this doesn't depend on v0.11 it doesn't matter, which is a good thing, we want more features into 0.10 :) |
|
agreed ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I totally overlooked that
overflowis stored as string, although the type osBoolwhich is perfectly fine in attributes.I think we should clean that up but it's a bit embarrassing that we already need v1.1 for the format spec 🙈 On the other hand, that's what is meant for...
This PR still supports strings as
overflowbut now writesBool, which cannot be read withFHist.jl v0.10.6without a warning (technically it's probably more likely a v2.0, but let's not exaggerate it?)I am also not 100% happy with the version checking yet, I guess I need a tea first, it was a very short night ;)