Feature/add share button #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ItayElgazar
reviewed
Mar 23, 2020
RoySegall
reviewed
Mar 23, 2020
aharonha
reviewed
Mar 23, 2020
| @@ -24,6 +24,13 @@ export interface Config { | |||
| ar: { title: string, body: string }, | |||
| duration: number | |||
| }, | |||
| downloadMohLandingPage: { | |||
There was a problem hiding this comment.
I know it's a minor thing but please organize this block in the same way the other download blocks organized:
he
en
ru
ar
am
|
Thanks for the reviews. But I'd be happy to see any response from the maintainer first. |
|
@MiriShalev This is an important feature |
|
Hi @kaminskypavel, Thank's for the awesome contribution. We intend to add this feature at the next version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a share button to make it easier to share within the app.
the link sent is respecting the locale