Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New linting rule to detect import issues #106

Merged
merged 4 commits into from
Dec 6, 2022
Merged

New linting rule to detect import issues #106

merged 4 commits into from
Dec 6, 2022

Conversation

pirelenito
Copy link
Member

@pirelenito pirelenito commented Dec 6, 2022

As an example, we have cyclic dependencies that can cause issues with some Webpack environments.

More information on the setup: https://github.com/import-js/eslint-plugin-import#typescript

As an example, we have cyclic dependencies that can cause issues with some Webpack environments.
This fixes the following lint error:

```
  241:14  error  Multiple exports of name 'fireEvent'  import/export
  242:1   error  Multiple exports of name 'fireEvent'  import/export
```
@pirelenito pirelenito marked this pull request as ready for review December 6, 2022 10:57
Copy link
Contributor

@jacobbergdahl jacobbergdahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Paulo 👍

@pirelenito pirelenito merged commit bfbcc7c into main Dec 6, 2022
@pirelenito pirelenito deleted the import-fixes branch December 6, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants