Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Style updates not properly cleaning previous subscriptions #11

Merged
merged 6 commits into from
Nov 4, 2021
Merged

Fix Style updates not properly cleaning previous subscriptions #11

merged 6 commits into from
Nov 4, 2021

Commits on Nov 4, 2021

  1. Adds unit tests that checks that indeed we are adding more subscripti… 

    …ons to style Facets
    @pirelenito
    pirelenito committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    5bd9c22 View commit details
    Browse the repository at this point in the history

  2. Adds new test that verifies we are subscribing when updating to a new… 

    … facet
    @pirelenito
    pirelenito committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    90444e9 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into fix-style-updates

    @pirelenito
    pirelenito committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    5815136 View commit details
    Browse the repository at this point in the history

  4. Check if the value has changed before subscribing again

    @pirelenito
    pirelenito committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    c74f982 View commit details
    Browse the repository at this point in the history

  5. Adds a couple more unit tests o updating styles

    @pirelenito
    pirelenito committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    9e024aa View commit details
    Browse the repository at this point in the history

  6. Rename the tests

    @pirelenito
    pirelenito committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    0b34cba View commit details
    Browse the repository at this point in the history