Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move responsibility of cleaning up effects from facets to useEffect() / useFacetEffect() #96

Merged
merged 7 commits into from
Oct 24, 2022
Merged

Move responsibility of cleaning up effects from facets to useEffect() / useFacetEffect() #96

merged 7 commits into from
Oct 24, 2022

Commits on Oct 18, 2022

  1. - Remove cleanup logic in createFacet.ts 

    - Re-implement cleanup logic in useFacetEffect()
- Create a factory for creating useFacetEffect() and useFacetLayoutEffect()
- Exclude /dist folder when running unit tests
    @AdamRamberg
    AdamRamberg committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    2f51a6e View commit details
    Browse the repository at this point in the history

  2. Update the description of the integration unit test

    @AdamRamberg
    AdamRamberg committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    ab3a08f View commit details
    Browse the repository at this point in the history

  3. Use workspace ranges for dependencies. 

    See this for more info: https://yarnpkg.com/features/workspaces#workspace-ranges-workspace
    @AdamRamberg
    AdamRamberg committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    5b76def View commit details
    Browse the repository at this point in the history

  4. Revert "Use workspace ranges for dependencies." 

    This reverts commit 5b76def.
    @AdamRamberg
    AdamRamberg committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    66b2512 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. Update docs for contributing

    @AdamRamberg
    AdamRamberg committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    5c131c8 View commit details
    Browse the repository at this point in the history

  2. Use effectMemoized and make the function returned from createUseFacet… 

    …Effect unnamed.
    @AdamRamberg
    AdamRamberg committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    d9196cb View commit details
    Browse the repository at this point in the history

  3. Minor adjustment to contributions docs

    @AdamRamberg
    AdamRamberg committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    340fd3a View commit details
    Browse the repository at this point in the history