Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect geoip test data and skip if not there #752

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Detect geoip test data and skip if not there #752

merged 1 commit into from
Sep 15, 2023

Conversation

bennybp
Copy link
Contributor

@bennybp bennybp commented Sep 15, 2023

Description

Skip tests that require geoip data if the test data is not cloned into qcarchivetesting

Fixes #718

Changelog description

Tests requiring geoip test data are now automatically skipped if not available

Status

  • Code base linted
  • Ready to go

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #752 (230386b) into main (d06773d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@bennybp bennybp merged commit ee3504f into main Sep 15, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove or patch geoip2 tests
1 participant