Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add expression and expression subcategory page #233

Merged
merged 13 commits into from
Aug 28, 2022

Conversation

120EE0692
Copy link
Member

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your default branch!
  • Make sure you are making a pull request against the default branch (left side). Also you should start your branch off default branch.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.
  • I have added necessary documentation (if appropriate)

Linked Issues

Fixes

Description

add expression and expression subcategory page
Only wisdom, Editorial and Miscellaneous were added.
Remaining will be added later.

❤️Thank you!

Post merge checklist

  • Follow steps from the guidelines for contributing to this repository.
  • If you are a new contributor, ping in the thread and one of the maintainers will add you to all-contributors list.

@120EE0692 120EE0692 self-assigned this Jun 19, 2022
@120EE0692 120EE0692 added enhancement New feature or request wip Work In Progress labels Jun 19, 2022
@120EE0692 120EE0692 requested a review from rutajdash July 3, 2022 09:40
Copy link
Member

@rutajdash rutajdash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@120EE0692
I recommend having a custom subcategory filter (in the getStaticProps section) for the catch-all file as we have varied non-article subcategories in the editorial. Also, consider if a catch-all would work here since the UI may differ for each.

@rutajdash
Copy link
Member

image
@120EE0692 ?

@120EE0692
Copy link
Member Author

@120EE0692 I recommend having a custom subcategory filter (in the getStaticProps section) for the catch-all file as we have varied non-article subcategories in the editorial. Also, consider if a catch-all would work here since the UI may differ for each.

Non-article subcategories are yet not prepared.

@120EE0692
Copy link
Member Author

120EE0692 commented Jul 3, 2022

image @120EE0692 ?

image

@rutajdash

@120EE0692 120EE0692 requested a review from rutajdash July 3, 2022 16:19
@rutajdash
Copy link
Member

@120EE0692 I recommend having a custom subcategory filter (in the getStaticProps section) for the catch-all file as we have varied non-article subcategories in the editorial. Also, consider if a catch-all would work here since the UI may differ for each.

Non-article subcategories are yet not prepared.

I understand, however, it is better to have the filter from now itself. And display not-found for others.

@rutajdash
Copy link
Member

image @120EE0692 ?

image

@rutajdash

The error is still persisting in a clean environment, please see what is the issue.

@120EE0692
Copy link
Member Author

image @120EE0692 ?

image @rutajdash

The error is still persisting in a clean environment, please see what is the issue.

@rutajdash
image
When I am using this this is working fine.

As I noticed in the production database the podcast and editorial subcategory, numbers get swapped. Hence I also change in app. Maybe in this link https://project-reclamation-staging.herokuapp.com/v1/graph the number may not get swapped, and hence when it makes the request for the editorial it get a null response.

@rutajdash rutajdash merged commit 987162d into Monday-Morning:main Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wip Work In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants