-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add expression and expression subcategory page #233
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@120EE0692
I recommend having a custom subcategory filter (in the getStaticProps section) for the catch-all file as we have varied non-article subcategories in the editorial. Also, consider if a catch-all would work here since the UI may differ for each.
Non-article subcategories are yet not prepared. |
I understand, however, it is better to have the filter from now itself. And display not-found for others. |
@rutajdash @rutajdash As I noticed in the production database the podcast and editorial subcategory, numbers get swapped. Hence I also change in app. Maybe in this link https://project-reclamation-staging.herokuapp.com/v1/graph the number may not get swapped, and hence when it makes the request for the editorial it get a null response. |
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Linked Issues
Fixes
Description
add expression and expression subcategory page
Only wisdom, Editorial and Miscellaneous were added.
Remaining will be added later.
❤️Thank you!
Post merge checklist