-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replace old portfolio #240
Merged
rutajdash
merged 11 commits into
Monday-Morning:main
from
120EE0692:feat/redirect-to-new-portfolio
Aug 27, 2022
Merged
feat: replace old portfolio #240
rutajdash
merged 11 commits into
Monday-Morning:main
from
120EE0692:feat/redirect-to-new-portfolio
Aug 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
120EE0692
added
enhancement
New feature or request
wip
Work In Progress
bugfix
Some Bug was Fixed
labels
Jul 22, 2022
rutajdash
requested changes
Jul 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure the following:
- If someone opens a profile page which is
/portfolio/<newUserId>
, redirect it to/portfolio/<newUserId>/<generatedUserName
- If someone opens a profile page which is
/portfolio/<newUserId>/<invalidUserName>
, redirect it to/portfolio/<newUserId>/<generatedUserName
- The generatedUserName must be
<firstName>_<lastName>
- If anyone opens
/portfolio/<oldUserName>
, redirect it to/portfolio/<newUserId>/<generatedUserName
- If anyone has an Email Id as
transfer-<something>@gmail.com
, do not show any email ID. - Use revalidate set to once a week.
@120EE0692 Tag me and let me know once the following is done.
|
@120EE0692 please complete the mentioned tasks. |
rutajdash
requested changes
Aug 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- User slug check logic is inefficient.
- Unnecessary details in getUserByOldUserName
rutajdash
approved these changes
Aug 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Description
Activate the user old portfolio page in new website
❤️Thank you!
Post merge checklist