Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace old portfolio #240

Merged

Conversation

120EE0692
Copy link
Member

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your default branch!
  • Make sure you are making a pull request against the default branch (left side). Also you should start your branch off default branch.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.
  • I have added necessary documentation (if appropriate)

Description

Activate the user old portfolio page in new website

❤️Thank you!

Post merge checklist

  • Follow steps from the guidelines for contributing to this repository.
  • If you are a new contributor, ping in the thread and one of the maintainers will add you to all-contributors list.

@120EE0692 120EE0692 added enhancement New feature or request wip Work In Progress bugfix Some Bug was Fixed labels Jul 22, 2022
@120EE0692 120EE0692 self-assigned this Jul 22, 2022
@120EE0692 120EE0692 requested a review from rutajdash July 22, 2022 12:37
Copy link
Member

@rutajdash rutajdash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure the following:

  1. If someone opens a profile page which is /portfolio/<newUserId>, redirect it to /portfolio/<newUserId>/<generatedUserName
  2. If someone opens a profile page which is /portfolio/<newUserId>/<invalidUserName>, redirect it to /portfolio/<newUserId>/<generatedUserName
  3. The generatedUserName must be <firstName>_<lastName>
  4. If anyone opens /portfolio/<oldUserName>, redirect it to /portfolio/<newUserId>/<generatedUserName
  5. If anyone has an Email Id as transfer-<something>@gmail.com, do not show any email ID.
  6. Use revalidate set to once a week.

client/src/pages/portfolio/[userId]/[name].jsx Outdated Show resolved Hide resolved
client/src/pages/portfolio/[userId].jsx Outdated Show resolved Hide resolved
@rutajdash
Copy link
Member

@120EE0692 Tag me and let me know once the following is done.

Ensure the following:

  1. If someone opens a profile page which is /portfolio/<newUserId>, redirect it to /portfolio/<newUserId>/<generatedUserName
  2. If someone opens a profile page which is /portfolio/<newUserId>/<invalidUserName>, redirect it to /portfolio/<newUserId>/<generatedUserName
  3. The generatedUserName must be <firstName>_<lastName>
  4. If anyone opens /portfolio/<oldUserName>, redirect it to /portfolio/<newUserId>/<generatedUserName
  5. If anyone has an Email Id as transfer-<something>@gmail.com, do not show any email ID.

@rutajdash
Copy link
Member

@120EE0692 please complete the mentioned tasks.

Copy link
Member

@rutajdash rutajdash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. User slug check logic is inefficient.
  2. Unnecessary details in getUserByOldUserName

@rutajdash rutajdash merged commit b09b392 into Monday-Morning:main Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Some Bug was Fixed enhancement New feature or request wip Work In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants