Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to .NET Standard 2.0 #1

Merged
merged 2 commits into from
Jun 16, 2021
Merged

Migration to .NET Standard 2.0 #1

merged 2 commits into from
Jun 16, 2021

Conversation

ktos
Copy link
Contributor

@ktos ktos commented Jun 8, 2021

The package now supports .NET Standard 2.0, so it is available for Xamarin, Unity, UWP, etc. (and is not showing errors in .NET 5 or later anymore).

@ktos
Copy link
Contributor Author

ktos commented Jun 8, 2021

Zamiast Nuget.Build.Packaging teraz buduje się paczkę używając standardowego polecenia w .NET 5 - po prostu dotnet pack i dostajesz .nupkg.

@Mondonno
Copy link
Owner

Mondonno commented Jun 13, 2021

@ktos i saw that you migrated the files from Airly.Net/contents/* to Airly.Net/* why? Also what's changing with deleting the assembly info file and why you deleted it? All other things looks very good 👍

@Mondonno Mondonno self-assigned this Jun 13, 2021
@Mondonno Mondonno added the enhancement New feature or request label Jun 13, 2021
Copy link
Owner

@Mondonno Mondonno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain deletion of AssemblyInfo.cs, packages.config, also visual studio have some realy strange things when the test imported project does not depend on the same packages as the main project. Also explain the migration as i mentioned above. As I said above all other things look good 💯

@ktos
Copy link
Contributor Author

ktos commented Jun 16, 2021

  • packages.config is not needed anymore, in new project system dependencies are in the .csproj file,
  • AssemblyInfo.cs was empty (identical to the default one), now it should be generated automatically during compilation,
  • Moving from content/ - I thought you moved everything to content/ to avoid source code merging with project configuration (e.g. packages.config). I think we can move it back, it does not matter actually,
  • dotnet test had no problems after removing dependency - I've not tested on VS for Mac; it can be reverted, but the dependent version must be the same (13.0.0.2) as the original version (and was something like 12.0.0.0 and it conflicted).

Copy link
Owner

@Mondonno Mondonno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All unit-tests passed on my side 👍
So i think i'm able to merge this PR #1

@Mondonno Mondonno merged commit 35d69ea into Mondonno:main Jun 16, 2021
Mondonno added a commit that referenced this pull request Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request important
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants