Update CI / packaging to be in sync with MongoEngine #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony
force-pushed
the
tweak/travis-sync-and-with-mongoengine
branch
2 times, most recently
from
8b7608e
to
68adc6a
Compare
tony
changed the title
|
@touilleMan Any feedback on this (to add / remove?) |
tony
force-pushed
the
tweak/travis-sync-and-with-mongoengine
branch
2 times, most recently
from
9ab68af
to
c022cc8
Compare
This uses install_mongodb_on_travis.sh from MongoEngine 0.15.3 See also: https://github.com/MongoEngine/mongoengine/blob/v0.15.3/.travis.yml
Also adapt PYMONGO 3.x to be whatever the highest version under 4 is.
This will test against the latest patch release. So grab 0.15.3 (if it's the latest) verse 0.15.0. This assures that bug fix releases from MongoEngine is accounted for in CI.
tony
force-pushed
the
tweak/travis-sync-and-with-mongoengine
branch
from
c022cc8
to
10d9449
Compare
|
(Fixed issue where release hook was removed in rebase) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, It's hard to get coverage for PR's like #346.
Right now this package has classifiers for Python 2.6, 3.2 and travis matrix'd against older python versions. In addition, there were versions of MongoEngine that go back to 0.11. (Which we could re-add if needed)
I'm not sure if there's a standard, but I opted to match where MongoEngine's current stable release is at. Edit: I expanded it to cover pymongo 3.6, 3.7, and made 3.x work for whichever release is <4 (hopefully more future safe?)
Also, to add coverage, particularly in cases where pymongo versions diverge (e.g. #346) I'm adding support for PyMongo in the test matrix, in edition to MongoEngine itself.