Marshmallow v3 Compatibility #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 3, 2019 13:17
Unrelated issue popped in travis-ci
|
python 2 is broken with this change. |
added 2 commits
October 4, 2019 05:16
…w v3 compatibility. If you need python2 and/or toasted support stick with v0.10.0
|
Bumped version to 0.30.0 (30 for v3) because this would include breaking changes.
Tests outside these are passing. People can stick with v0.10.0 if that's a problem. |
|
@qcho I am getting a problem when trying to use your branch (and the main branch too btw) to execute the tutorial code. I get this error Any ideas? |
ganeshghalame
approved these changes
Mar 27, 2020
|
any progress on this guys ? |
|
Any progress ?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wasn't working with marshmallow v3 because of several incompatible changes.
I managed to make it work with these changes.
The
func(v)call doesn't perform validations any-more. So I removed the wrong "errors" second param. But probably you need to advice where to perform this validation from now on if necessary.