Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple fixes for cascade=True save issues #2615

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Multiple fixes for cascade=True save issues #2615

wants to merge 9 commits into from

Commits on Dec 14, 2021

  1. Issue MongoEngine#1236 

    Save the children documents first to avoid the issue where a parent cannot save due to having new children documents.
    @nickfrev
    nickfrev committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    efca40d View commit details
    Browse the repository at this point in the history

  2. Added Testing for saving new ReferenceField with cascade

    @nickfrev
    nickfrev committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    bb6f7d8 View commit details
    Browse the repository at this point in the history

  3. Moved cascade save handling higher up to avoid validation errors.

    @nickfrev
    nickfrev committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    e9a9dba View commit details
    Browse the repository at this point in the history

  4. Updated Authors

    @nickfrev
    nickfrev committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    e0cc779 View commit details
    Browse the repository at this point in the history

  5. Removed unnecessary newlines at end of test.

    @nickfrev
    nickfrev committed Dec 14, 2021
    Configuration menu
    Copy the full SHA
    979e491 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2021

  1. Modularize the cascade save event 

    - Created a new base field (SaveableBaseField) which allows a field to marked as savable during a cascade save.
- Each SaveableBaseField defines a save method which describes how it will deal with a cascade save call this allows lists, dicts, and maps to be effected during a cascade save.
- Added an _is_saving flag during Document save to avoid saving a document that is already in the process of being saved. (Caused if there is a circular reference.)
    @nickfrev
    nickfrev committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    7fbdf8b View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2021

  1. Allowed ReferenceField cycles of unsaved documents 

    - Allows for users to cascade save unsaved documents even if a cycle exists.
    @nickfrev
    nickfrev committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    7672f2c View commit details
    Browse the repository at this point in the history

  2. Removed TOFIX comment that I fixed.

    @nickfrev
    nickfrev committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    ba400b7 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2022

  1. Merge branch 'master' into save-with-cascade-include-nested

    @nickfrev
    nickfrev authored May 7, 2022
    Configuration menu
    Copy the full SHA
    e6ef197 View commit details
    Browse the repository at this point in the history