Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPA checks + scripts.rpa handling #10212

Open
wants to merge 4 commits into
base: content
Choose a base branch
from

Conversation

ThePotatoGuy
Copy link
Member

@ThePotatoGuy ThePotatoGuy commented Feb 25, 2024

Changes

  • Re-added splash RPA check
  • added override to skip loading init code for script-poemgame
    • this was done by hooking into a spot between where early scripts are loaded and init scripts are loaded and removing the AST nodes for script-poemgame from renpy.game.script.initcode so it doesnt load later. (see override function comment for more info)
  • updated CI so it doesnt delete scripts.rpa anymore

Testing

loading with no rpas

  1. remove the DDLC rpas from the folder
  2. launch the mod
  3. verify the game shows the missing archives error

loading with scripts.rpa

  1. Add the DDLC rpas (including scripts.rpa)
  2. launch the mod
  3. verify the game launches / no crashes from scripts.rpa

@ThePotatoGuy ThePotatoGuy added awaiting testing code needs to be tested awaiting code review someone needs to check for syntax/logic/indentation errors labels Feb 25, 2024
@ThePotatoGuy ThePotatoGuy added this to the 0.13.0 milestone Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting code review someone needs to check for syntax/logic/indentation errors awaiting testing code needs to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants