Fix to avoid allocation/garbage when submitting OpenAL buffers. (#8178)

MonoGame · Feb 15, 2024 · c6e47a1 · c6e47a1
1 parent 2b4e406
commit c6e47a1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/MonoGame.Framework/Platform/Audio/OALSoundBuffer.cs b/MonoGame.Framework/Platform/Audio/OALSoundBuffer.cs
@@ -16,7 +16,7 @@ internal class OALSoundBuffer : IDisposable
 
 		public OALSoundBuffer()
 		{
-            AL.GenBuffers(1, out openALDataBuffer);
+            AL.GenBuffer(out openALDataBuffer);
             ALHelper.CheckError("Failed to generate OpenAL data buffer.");
 		}
 

diff --git a/MonoGame.Framework/Platform/Audio/OpenAL.cs b/MonoGame.Framework/Platform/Audio/OpenAL.cs
@@ -303,11 +303,12 @@ internal unsafe static void GenBuffers(int count, out int[] buffers)
             }
         }
 
-        internal static void GenBuffers(int count, out int buffer)
+        internal unsafe static void GenBuffer(out int buffer)
         {
-            int[] ret;
-            GenBuffers(count, out ret);
-            buffer = ret[0];
+            fixed (int* ptr = &buffer)
+            {
+                alGenBuffers(1, ptr);
+            }
         }
 
         internal static int[] GenBuffers(int count)