New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced touch mechanizm for Windows Phone. #2145
Conversation
…Touch.Frame reported**, due to loosing PointerReleased events and leaving ghost touches in TouchPanel. Issue #2140.
Can one of the admins verify this patch? |
1 similar comment
Can one of the admins verify this patch? |
No, it doesn't. I made this change (#2109) and created simple project displaying all touch points, and ghost touches remained. I wrote couple days ago about that in #2140. It's easy to repeat this bug by pressing screen with more than 5 fingers (On Lumias) at one time. Direct3DInterop mechanism goes crazy and doesn't send PointerReleased events. Due to this: bug is in Direct3DInterop implementation of touch handling. My fix is based on native silverlight, most responsive touch handling mechanism, which is Touch.FrameReported. After that change, I fired up my test project (and also my current primary project) and it works now without leaving ghost touches, |
Weird, I ran a test app on my htc 8x and could not get any ghost touches to appear even while tapping with 10 fingers at once. |
For me was weird why changing method from static to non-static would make a difference in ths case. There's only one surface, so there should be no difference. Anyway it didn't fix ghost touches when testing on Lumia 520. |
I tried this in our game and noticed that the touch positions are according to the orientation of the screen, while the previous method was always reporting in portrait (at least with DrawingSurfaceBackgroundGrid). |
Touch is a very delicate chunk of code... between this PR having a breaking change and it not being able to merge... seems like we should close this PR. To deal with these sorts of issues i proposed #2579 for creating a set of TouchPanel unit tests. This will allow us to make these sorts of fixes without breaking existing correct behaviors. |
Replaced Windows.Phone.Input.Interop manipulation mechanism to Touch.Frame reported, due to loosing PointerReleased events and leaving ghost touches in TouchPanel. Issue #2140.