Split SoundEffectInstance/SoundEffect on a per-API basis #2251
Conversation
XAudio SoundEffectInstance implementation. Removed or reversed DIRECTX defines.
SoundEffect and SoundEffectInstance implementation for Android
Straightened up defines.
PSM SoundEffectInstance and SoundEffect implementations. Moved WAV header construction into a utility method. Added PlatformCreateInstance for SoundEffect.CreateInstance(). Added some comments for clarity.
|
Note that the Android and OpenAL paths were merged together. I'm told that @KonajuGames has reworked some of the audio classes on Android. After this pull request, his should remove the Android changes here and be replaced with the new Android path |
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
@mgbot test |
|
Test FAILed. |
|
@mgbot test |
|
Test FAILed. |
|
@mgbot test |
|
Test PASSed. |
|
Woot! This can merge if you are good with it Steve. |
Split SoundEffectInstance/SoundEffect on a per-API basis
|
Merged. I will do the Android update soon. |
|
Fantastic! |
The goals for this pull request mirror those found in #2243, but for the SoundEffectInstance/SoundEffect classes. We chose to split each file into a XAudio, OpenAL, and PSM paths.
SoundEffectInstance and SoundEffect were split into partial classes, to help separate the code and clarify the growing confusing caused by constant #if/#elseif/#else chains and increase ease of future PRs. This also allows us to pull out common code to the "base" classes so that the behavior of these classes is more uniform.
Note that this pull request is all clean up; There should be no functional changes or new features, but please let me know if any pop up.
While merging these paths together, I did notice a lot bugs and logic errors. I tried to avoid fixing them, as that's a goal for a future PR. It's already confusing enough to view the diff of a restructure like this without changing implementation.