Make use of FileHelpers.NormalizeFilePathSeparators #2572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This depends on #2571 to be merged first, it adds |
|
@danzel - You'll need to merge in the latest changes from develop into this branch first. |
|
Yep, doing now :) |
|
Looks good... merging! |
tomspilman
added a commit
that referenced
this pull request
May 18, 2014
Make use of FileHelpers.NormalizeFilePathSeparators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of the FileHelpers things for #2555
This is an easy one that makes a nice cleanup, so submitting it by itself.
The remaining FileHelpers are mostly just used by StorageDevice, so maybe we leave them for now as #2389 is going to tackle them.
If you do plan on using the code in there,
DirectoryGetFilesandDirectoryGetDirectoriesboth ignore the given path on WINDOWS_STOREAPP.It looks like this bug was copy/pasted out of StorageDevice.
(I'll send a PR to fix them when I get a chance.)