Fixed #2075

[Nezz]

Cleaned up the usage of playingInternal to be WP only (#2075).

[tomspilman]

@dancolasanti - Can you verify this change solves your issue?

[tomspilman]

@dancolasanti - Can you verify this change solves your issue?

[dancolasanti]

Sorry for the late reply - I've been out of town this week - I will be home
Saturday and should be able to verify it then.

Date: Thu, 28 Aug 2014 16:41:18 -0700
From: notifications@github.com
To: MonoGame@noreply.github.com
CC: dancolasanti@hotmail.com
Subject: Re: [MonoGame] Fixed #2075 (#2946)

@dancolasanti - Can you verify this change solves your issue?

—
Reply to this email directly or view it on GitHub.

[dancolasanti]

@tomspilman I was unable to verify that this fix fully resolves the problem. I downloaded the latest MonoGame-Develop code, made the suggested fix, hooked it up to SharpDX 2.6.2, rebuilt it and ran my Invasion game with it. My original problem (that trying to stop the user's music after the user says that the game can do this) seems fixed (the user's music stops), but the new side-effect (since a year ago when I last looked into this) is that the game now doesn't recognize that the user's music is playing and so it never asks the user if it can take control of music in the first place. So now the game just takes control of the user's music (shutting it off) without asking the user if that is OK (despite having logic to ask the user this - same code as my original XNA-WP7 game) and starts playing its own music. I think that this is caused by MediaPlayer.GameHasControl returning true when it shouldn't, although I haven't been able to prove this because I'm having trouble getting a debug build of MonoGame that I can actually step-into functions with (and this is partially because I don't know how to properly reference SharpDX ARM & x86 assemblies within my MonoGame project. (If you know of documentation that shows how to do this, please let me know). I could probably be of more help with this and other issues that I found if only I could figure out how to get a proper MonoGame dev-build configured correctly and reference it in my game project. cc: @Nezz

[Nezz]

Detecting if the user's music is playing at launch works for us and it wasn't working without this fix. This is the code from this PR:

return (!playingInternal && State == MediaState.Playing) || MsMediaPlayer.GameHasControl;

playingInternal is true by default, so the first part is false, therefore we return what the platform (MsMediaPlayer) gives us. So GameHasControl returns a correct value as long as playingInternal is set to true.
playingInternal is set to false by playing a non-MediaLibrary song (e.g. your game music).
So this doesn't work if you open up the game, start the background music, then leave the game, start user music and return to the game. I personally do not plan to fix this case because it is rather complicated (user music and game music use two different players that can play at the same time) and isn't a store requirement.

@tomspilman Could you merge this PR so that future improvements can be made regarding GameHasControl? The bug described in #2075 ("Can't MediaPlayer.Stop User's Music to Play Game Music") was in fact fixed, even if there are some other problems with the MediaPlayer :)

[tomspilman]

Merging...