Fix autorotate behavior during launch on iOS

[prollin]

This could cause orientation issues when launching on iOS. Strangely it was working fine on iOS 8 but caused issues on the upcoming iOS 8.1 (I suspect this might be the cause for some ppl having orientation issues, depending on what they do in their Game.Initialize)

[prollin]

@totallyeviljake how is PresentationParameter.Clear() related to ShouldAutoRotate? Looking at the code I can't see how it would crash

[totallyeviljake]

If you use the PresentationParameters() after you clear it, then it would give you an exception. It has an unexpected side effect. The iOS world is far more picky than any other platform, and we have very little access prior to the UI manager affecting its changes..... so, this is not a problem for your to fix Philippe - it's mostly something to know about MonoGame on iOS.

[picobots]

@prollin Can you explain what you mean by "could cause orientation issues when launching on iOS"? What specifically happens? And are you using Xcode 6.1? iOS 8.1 Simulator? iOS 8.1 Beta on a real device?

@totallyeviljake I'm confused by what you're saying. Are you saying that changing this line of code causes a new potential issue on iOS?

[prollin]

@picobots prior to this fix, ShouldAutoRotate would return false until Game.IsInitialized is true. For our case, a Landscape game, it resulted in incorrect framebuffer orientation (width and height seemed reversed) if starting the game when the device was in portrait (or the other landscape mode).
It seemed to be working prior to the latest iOS 8.1 GM seed though.
In any case it seems valid to always want ShouldAutorotate to return true and only rely on the SupportedOrientations set by the user.

There are most likely other issues with iOS orientations, this fix is most likely not the root cause of the other stuff that is happening.

[tomspilman]

Ok... i'll merge this for now. We'll look for the other sources the bug from here.