New enum docs. #3470
Merged
New enum docs. #3470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| None = 0, | ||
| /// <summary> | ||
| /// Rotate 180 degrees around the Y axis before rendering. |
There was a problem hiding this comment.
Are you sure this is rotation? I think this is not rotation at all... it is literally flipping the sprite so the top and bottom are switched, but the left and right are not.
There was a problem hiding this comment.
Flip sprite to 180 degrees around the Y axis before rendering.
It is better ? I'l change as you wish.,
There was a problem hiding this comment.
Oh... I guess Y axis is the important bit here. It is trying to describe flipping as a rotation around a single axis. That seems confusing to me. Maybe a better description:
Render the sprite reversed along the X axis.
|
Looks all good to me... i'll merge once it finishes building. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs for
-VertexElementUsage
-VertexElementFormat
-TextureFilter
-TextureAddressMode
-SurfaceFormat
Fix licenses for all of those enums.
SurfaceFormat_Legacy is renamed to SurfaceFormatLegacy and marked internal instead of public.