Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Eto Dialogs] New Item Dialog #4728

Merged
merged 1 commit into from Apr 5, 2016
Merged

[Eto Dialogs] New Item Dialog #4728

merged 1 commit into from Apr 5, 2016

Conversation

harry-cpp
Copy link
Member

Discussed in #4238

Replaces new item/new template dialog.

Stuff done to the dialog:

  • redesigned the layout
    • headerbar and normal version can now use the same layout
    • less pointless empty space
  • implement check for if the file exists in target directory
  • always shows the extension that's gonna be added to the name

Before left, after right:
untitled

@tomspilman
Copy link
Member

Why is the new dialog a different size on Mac/Linux than Windows?

@tomspilman
Copy link
Member

Also are header bar buttons a very common thing on these platforms? Seems weird to me. Don't want MonoGame tools to be the weirdo tool that does things different from all other tools.

@harry-cpp
Copy link
Member Author

Why is the new dialog a different size on Mac/Linux than Windows?

They are actually pretty similar in sizes, headerbar counts into client size so it eats up a bit of height (and a bit of width), look at bellow image.

Also are header bar buttons a very common thing on these platforms?

Common on GNOME, not common for the rest, so depending on if it's running under GNOME it will decided if it will use it: https://github.com/mono/MonoGame/blob/develop/Tools/Pipeline/Eto/Global.cs#L19

This is what it looks like if it's not running under GNOME:
untitled

@tomspilman
Copy link
Member

They are actually pretty similar in sizes

The dialogs are clearly different sizes... but I guess the smaller font size on Windows is fooling me a bit too.

This is what it looks like if it's not running under GNOME:

Ok... as long as it is only different in places where it is expected.

@tomspilman tomspilman merged commit 215eed3 into MonoGame:develop Apr 5, 2016
@harry-cpp harry-cpp deleted the ed3 branch April 5, 2016 17:38
@harry-cpp
Copy link
Member Author

The dialogs are clearly different sizes... but I guess the smaller font size on Windows is fooling me a bit too.

Different DPI more likely.

@tomspilman
Copy link
Member

True.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants