Fix proposal for added O(1) EffectParameter lookups by name #6146 #6191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes lookup dictionary hold names and indexes instead of names and EffectParameters
|
Let's get this merged! :) |
|
I'll merge this for now... but we should find the root cause of this issue and fix it. |
|
@alkher tested this and it seems to work for now. |
nkast
pushed a commit
to nkast/MonoGame
that referenced
this pull request
Jun 26, 2018
…6146 (MonoGame#6191) Fixes bug when adding parameters without name or null as name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since @alkher pointed out in #6184 that
EffectParametersalso get allocated for arrays (and maybe even lines of array declarations), I prepared this fix.IMO it would be better to not add those to the
EffectParameterCollectionin the first place, I lack the experience to see the full consequences of such a change (and the lack of tests doesn't do any good either).So with this fix everyone would be able to use shaders containing (constant) arrays again.