Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch order of parameters in Ray.Deconstruct #6198

Merged
merged 2 commits into from
Feb 21, 2018

Conversation

KonajuGames
Copy link
Contributor

@KonajuGames KonajuGames commented Feb 20, 2018

The parameters in the type deconstructors should match the order of the parameters in the constructors.

Completes #6096

The parameters in the type deconstructors should match the order of the parameters in the constructors.
@dellis1972
Copy link
Contributor

@KonajuGames looks like the unit tests failed.

`[MonoGameTests.exe] MonoGame.Tests.Framework.RayTest.Deconstruct
[09:40:03]
[MonoGame.Tests.Framework.RayTest.Deconstruct] Test(s) failed. Expected: {X:0 Y:0 Z:1}
But was: {X:1 Y:0 Z:0}
[09:40:03]
[MonoGame.Tests.Framework.RayTest.Deconstruct] Test(s) failed. Expected: {X:0 Y:0 Z:1}
But was: {X:1 Y:0 Z:0}

at NUnit.Framework.Assert.That(Object actual, IResolveConstraint expression, String message, Object[] args)
at MonoGame.Tests.Framework.RayTest.Deconstruct() in c:\BuildAgents\MonoGameWin2\work\59a4b66548a5cef5\Test\Framework\RayTest.cs:line 59
[09:40:06][Step 1/1] Failed tests detected`

@KonajuGames
Copy link
Contributor Author

KonajuGames commented Feb 20, 2018 via email

@Jjagg
Copy link
Contributor

Jjagg commented Feb 20, 2018

That's why we have unit tests.

Though it's the test that should be fixed in this case :p

@KonajuGames
Copy link
Contributor Author

Though it's the test that should be fixed in this case :p

Well, yes, of course. I overlooked the test and hadn't run them locally first. Fix incoming...

@dellis1972 dellis1972 merged commit 46f90ee into MonoGame:develop Feb 21, 2018
@dellis1972
Copy link
Contributor

Merged :)

nkast pushed a commit to nkast/MonoGame that referenced this pull request Jun 26, 2018
* Switch order of parameters in Ray.Deconstruct

The parameters in the type deconstructors should match the order of the parameters in the constructors.

* Fixed Ray.Deconstruct test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants