Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator fails if there is no Background color set #25

Closed
sk33z3r opened this issue Mar 21, 2022 · 2 comments
Closed

Generator fails if there is no Background color set #25

sk33z3r opened this issue Mar 21, 2022 · 2 comments

Comments

@sk33z3r
Copy link
Collaborator

sk33z3r commented Mar 21, 2022

If the traits.py file has no background set, python tries to get the first image from a folder named layer00 which doesn't jive with the way we have things explained in the docs.

Either we have to be specific about the need to keep background color in traits, even if you don't want it; or we add logic that says "if Background Color" doesn't exist, start at layer01.

The preferable solution is the latter, so people that don't care about background and have one set in images already won't get confused.

@sk33z3r
Copy link
Collaborator Author

sk33z3r commented Mar 21, 2022

I just raise a more specific error as a temporary solution, and added a note to the comments of traits.example.py

@sk33z3r
Copy link
Collaborator Author

sk33z3r commented Mar 21, 2022

Thought of a better solution for this, tested and pushed. Now you can remove the background layer from the dict and it will adjust layers accordingly.

This does require the Background Color layer to be the first layer in the dict, still, but it's explained in the docs this should be the case any way.

@sk33z3r sk33z3r closed this as completed Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant