feat: 🚧 set up pallet providers skeleton

Cargo.toml

@@ -9,7 +9,7 @@ homepage = "https://moonsonglabs.com/"
 panic = "unwind"
 
 [workspace]
-members = ["runtime", "pallets/*", "node", "bsp", "msp", "storage-kit"]
+members = ["runtime", "pallets/*", "node", "bsp", "msp", "storage-kit", "support/*"]
 resolver = "2"
 
 [workspace.lints.rust]

pallets/proofs-dealer/Cargo.toml

@@ -15,14 +15,21 @@ workspace = true
 targets = ["x86_64-unknown-linux-gnu"]
 
 [dependencies]
-codec = { package = "parity-scale-codec", version = "3.0.0", features = ["derive"], default-features = false }
-scale-info = { version = "2.10.0", default-features = false, features = ["derive"] }
+codec = { package = "parity-scale-codec", version = "3.0.0", features = [
+	"derive",
+], default-features = false }
+scale-info = { version = "2.10.0", default-features = false, features = [
+	"derive",
+] }
+
+# Local
+storage-hub-traits = { path = "../../support/traits", version = "0.1.0", default-features = false }
 
 # Substrate
 frame-benchmarking = { git = "https://github.com/paritytech/polkadot-sdk.git", tag = "polkadot-v1.5.0", default-features = false, optional = true }
 frame-support = { git = "https://github.com/paritytech/polkadot-sdk.git", tag = "polkadot-v1.5.0", default-features = false }
 frame-system = { git = "https://github.com/paritytech/polkadot-sdk.git", tag = "polkadot-v1.5.0", default-features = false }
-sp-trie = { git = "https://github.com/paritytech/polkadot-sdk.git", tag = "polkadot-v1.5.0", default-features = false  }
+sp-trie = { git = "https://github.com/paritytech/polkadot-sdk.git", tag = "polkadot-v1.5.0", default-features = false }
 
 [dev-dependencies]
 serde = { version = "1.0.193" }

pallets/proofs-dealer/src/lib.rs

@@ -17,16 +17,7 @@ pub use pallet::*;
 pub mod types;
 pub mod utils;
 
-use codec::FullCodec;
-use frame_support::{
-    inherent::IsFatalError,
-    pallet_prelude::*,
-    sp_runtime::{
-        traits::{CheckEqual, MaybeDisplay, SimpleBitOps},
-        RuntimeString,
-    },
-    traits::fungible,
-};
+use frame_support::{inherent::IsFatalError, pallet_prelude::*, sp_runtime::RuntimeString};
 use scale_info::prelude::fmt::Debug;
 use sp_trie::CompactProof;
 
@@ -45,6 +36,7 @@ pub mod pallet {
     use frame_system::pallet_prelude::*;
     use scale_info::prelude::fmt::Debug;
     use sp_trie::CompactProof;
+    use storage_hub_traits::ProvidersInterface;
     use types::ProviderFor;
 
     use crate::types::*;
@@ -57,7 +49,7 @@ pub mod pallet {
 
         /// The Providers pallet.
         /// To check if whoever submits a proof is a registered Provider.
-        type ProvidersPallet: crate::ProvidersInterface<AccountId = Self::AccountId>;
+        type ProvidersPallet: ProvidersInterface<AccountId = Self::AccountId>;
 
         /// Type to access the Balances Pallet.
         type NativeBalance: fungible::Inspect<Self::AccountId>
@@ -390,47 +382,6 @@ impl InherentError {
     }
 }
 
-/// A trait to lookup registered Providers, their Merkle Patricia Trie roots and their stake.
-///
-/// It is abstracted over the `AccountId` type, `Provider` type, `Balance` type and `MerkleHash` type.
-pub trait ProvidersInterface {
-    /// The type which can be used to identify accounts.
-    type AccountId: Parameter + Member + MaybeSerializeDeserialize + Debug + Ord + MaxEncodedLen;
-    /// The type which represents a registered Provider.
-    type Provider: Parameter + Member + MaybeSerializeDeserialize + Debug + Ord + MaxEncodedLen;
-    /// The type corresponding to the staking balance of a registered Provider.
-    type Balance: fungible::Inspect<Self::AccountId> + fungible::hold::Inspect<Self::AccountId>;
-    /// The type corresponding to the root of a registered Provider.
-    type MerkleHash: Parameter
-        + Member
-        + MaybeSerializeDeserialize
-        + Debug
-        + MaybeDisplay
-        + SimpleBitOps
-        + Ord
-        + Default
-        + Copy
-        + CheckEqual
-        + AsRef<[u8]>
-        + AsMut<[u8]>
-        + MaxEncodedLen
-        + FullCodec;
-
-    /// Check if an account is a registered Provider.
-    fn is_provider(who: Self::Provider) -> bool;
-
-    // Get Provider from AccountId, if it is a registered Provider.
-    fn get_provider(who: Self::AccountId) -> Option<Self::Provider>;
-
-    /// Get the root for a registered Provider.
-    fn get_root(who: Self::Provider) -> Option<Self::MerkleHash>;
-
-    /// Get the stake for a registered  Provider.
-    fn get_stake(
-        who: Self::Provider,
-    ) -> Option<<Self::Balance as fungible::Inspect<Self::AccountId>>::Balance>;
-}
-
 // TODO: Move this to a primitives crate.
 // TODO: Abstract better the types of arguments
 /// A trait to verify Merkle Patricia Trie proofs.

pallets/proofs-dealer/src/types.rs

@@ -1,6 +1,7 @@
 use codec::{Decode, Encode};
 use frame_support::traits::fungible;
 use scale_info::TypeInfo;
+use storage_hub_traits::ProvidersInterface;
 
 #[derive(Debug, Clone, PartialEq, Decode, Encode, TypeInfo)]
 pub enum ProofRejectionReason {
@@ -41,8 +42,7 @@ pub type ChallengesQueueLengthFor<T> = <T as crate::Config>::ChallengesQueueLeng
 pub type ProvidersPalletFor<T> = <T as crate::Config>::ProvidersPallet;
 
 /// Syntactic sugar for the Provider type used in the proofs pallet.
-pub type ProviderFor<T> =
-    <<T as crate::Config>::ProvidersPallet as crate::ProvidersInterface>::Provider;
+pub type ProviderFor<T> = <<T as crate::Config>::ProvidersPallet as ProvidersInterface>::Provider;
 
 /// Syntactic sugar for the type of Balance used in the NativeBalances pallet.
 pub type BalanceFor<T> = <<T as crate::Config>::NativeBalance as fungible::Inspect<

pallets/proofs-dealer/src/utils.rs

@@ -3,11 +3,12 @@
 use frame_support::{ensure, pallet_prelude::DispatchResult};
 use frame_system::pallet_prelude::BlockNumberFor;
 use sp_trie::CompactProof;
+use storage_hub_traits::ProvidersInterface;
 
 use crate::{
     pallet,
     types::{AccountIdFor, BalanceFor, FileKeyFor, ProviderFor, ProvidersPalletFor},
-    ChallengesQueue, Error, Pallet, ProvidersInterface,
+    ChallengesQueue, Error, Pallet,
 };
 
 impl<T> Pallet<T>

pallets/providers/Cargo.toml

@@ -0,0 +1,65 @@
+[package]
+name = "pallet-storage-providers"
+description = "FRAME pallet that works as a registry for storage providers (both main and backup ones)"
+version = "0.1.0"
+homepage = { workspace = true }
+license = { workspace = true }
+authors = { workspace = true }
+repository = { workspace = true }
+edition = { workspace = true }
+
+[lints]
+workspace = true
+
+[package.metadata.docs.rs]
+targets = ["x86_64-unknown-linux-gnu"]
+
+[dependencies]
+codec = { package = "parity-scale-codec", version = "3.0.0", features = [
+	"derive",
+], default-features = false }
+scale-info = { version = "2.10.0", default-features = false, features = [
+	"derive",
+] }
+
+# Local
+storage-hub-traits = { path = "../../support/traits", version = "0.1.0", default-features = false}
+
+# Substrate
+frame-benchmarking = { git = "https://github.com/paritytech/polkadot-sdk.git", tag = "polkadot-v1.5.0", default-features = false, optional = true }
+frame-support = { git = "https://github.com/paritytech/polkadot-sdk.git", tag = "polkadot-v1.5.0", default-features = false }
+frame-system = { git = "https://github.com/paritytech/polkadot-sdk.git", tag = "polkadot-v1.5.0", default-features = false }
+
+[dev-dependencies]
+serde = { version = "1.0.193" }
+pallet-balances = { version = "4.0.0-dev", git = "https://github.com/paritytech/polkadot-sdk.git", tag = "polkadot-v1.5.0" }
+
+
+# Substrate
+sp-core = { git = "https://github.com/paritytech/polkadot-sdk.git", tag = "polkadot-v1.5.0", default-features = false }
+sp-io = { git = "https://github.com/paritytech/polkadot-sdk.git", tag = "polkadot-v1.5.0", default-features = false }
+sp-runtime = { git = "https://github.com/paritytech/polkadot-sdk.git", tag = "polkadot-v1.5.0", default-features = false }
+
+[features]
+default = ["std"]
+runtime-benchmarks = [
+	"frame-benchmarking/runtime-benchmarks",
+	"frame-support/runtime-benchmarks",
+	"frame-system/runtime-benchmarks",
+	"sp-runtime/runtime-benchmarks",
+]
+std = [
+	"codec/std",
+	"frame-benchmarking/std",
+	"frame-support/std",
+	"frame-system/std",
+	"scale-info/std",
+	"sp-core/std",
+	"sp-io/std",
+	"sp-runtime/std",
+]
+try-runtime = [
+	"frame-support/try-runtime",
+	"frame-system/try-runtime",
+	"sp-runtime/try-runtime",
+]

pallets/providers/README.md

@@ -0,0 +1 @@
+License: Unlicense

pallets/providers/src/benchmarking.rs

@@ -0,0 +1,24 @@
+//! Benchmarking setup for pallet-providers
+
+/* use super::*;
+
+#[allow(unused)]
+use crate::Pallet as StorageProviders;
+use frame_benchmarking::{benchmarks, impl_benchmark_test_suite, whitelisted_caller};
+use frame_system::RawOrigin;
+
+benchmarks! {
+    do_something {
+        let s in 0 .. 100;
+        let caller: T::AccountId = whitelisted_caller();
+    }: _(RawOrigin::Signed(caller), s)
+    verify {
+        assert_eq!(Something::<T>::get(), Some(s));
+    }
+}
+
+impl_benchmark_test_suite!(
+    StorageProviders,
+    crate::mock::new_test_ext(),
+    crate::mock::Test,
+); */