Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of Commons for 1.19+ #5

Merged
merged 5 commits into from
Jul 3, 2023
Merged

Removal of Commons for 1.19+ #5

merged 5 commits into from
Jul 3, 2023

Conversation

Sefiraat
Copy link
Collaborator

@Sefiraat Sefiraat commented Jun 25, 2022

Description

Update for Spigot 1.19 (does not include upping Spigot version due to issues I cannot resolve currently).

Code Changes

Removes all ties to commons.lang. StringUtils replaced with a like-for-like method and ArrayUtils for stream#mapToInt()

Related Issues

Checklist

  • I have also tested the proposed changes with an addon.
  • I followed the existing code standards and didn't mess up the formatting.
  • I have added Nullable or Nonnull annotations to my methods
  • I have added sufficient Unit Tests to cover my code.
  • I updated the version in pom.xml according to semantic versioning.

@Sefiraat Sefiraat changed the title Removal of Commons, Spigot 1.19 Removal of Commons for 1.19+ Jun 25, 2022
@Sefiraat Sefiraat marked this pull request as ready for review June 25, 2022 11:42
@Sefiraat Sefiraat requested review from Mooy1 and FN-FAL113 June 25, 2022 11:42
@Sefiraat
Copy link
Collaborator Author

Not to be merged until testing on an addon using InfinityLib (Ill first test with Infinity Expansion in an IE PR) has been completed and validated.

@Sefiraat Sefiraat self-assigned this Jun 25, 2022
@ybw0014
Copy link

ybw0014 commented Jul 11, 2022

Test passed in this PR: Mooy1/InfinityExpansion#109

@Sefiraat Sefiraat merged commit 64c78e7 into master Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants