Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The height is weird in some Android browsers like 360 #8

Closed
MopTym opened this issue Jan 6, 2016 · 2 comments
Closed

The height is weird in some Android browsers like 360 #8

MopTym opened this issue Jan 6, 2016 · 2 comments

Comments

@MopTym
Copy link
Owner

MopTym commented Jan 6, 2016

I found that in 360 Android browser, which has an auto-hide location bar, the height of DoSlide becomes weird that couldn't fill to 100%.
@MopTym MopTym changed the title The height is weird in some Android browser like 360 The height is weird in some Android browsers like 360 Jan 6, 2016
@MopTym
Copy link
Owner Author

MopTym commented Jan 6, 2016

I think the problem is caused by css render order.

DoSlide is different from fullpage.js, it use % instead of px to realize size adaptation. When scrolling, location bar of the browser may auto hide, it causes the change of viewport height which makes rendering be incorrect .

The solution is simple: Do not use <body> as parent element.

@MopTym MopTym closed this as completed in 5964683 Jan 6, 2016
MopTym added a commit that referenced this issue Jan 6, 2016
@MopTym
Do not use '<body>' as parent element (#8)
ddb174c
MopTym added a commit that referenced this issue Jan 6, 2016
@MopTym
Merge pull request #9 from MopTym/dev
c609652 
Do not use '<body>' as parent element (close #8)
@MopTym MopTym reopened this Jan 6, 2016
@MopTym
Copy link
Owner Author

MopTym commented Jan 6, 2016

The problem may be caused by scrollbar, I'm not sure, but the solution is right.

@MopTym MopTym closed this as completed Jan 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MopTym