Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added background and border for Errors, Warnings, and Hints #17

Merged
merged 1 commit into from
Aug 4, 2024

Conversation

Suhaybu
Copy link
Contributor

@Suhaybu Suhaybu commented Aug 4, 2024

The change

Backgrounds for Errors, Warnings and Hints now share the same color with elevated_surface.background. The border's of these hints now use a darker shade of their respective colors.

Visual Preview of the changes

Error popup

CleanShot 2024-08-05 at 00 13 00

Warning popup

CleanShot 2024-08-05 at 00 13 40

Hint popup

CleanShot 2024-08-05 at 00 13 23

Test it yourself

To test the proposed changes before it's merged, add thiS to your Zed's settings.json

{
  "experimental.theme_overrides": {
    "error.background": "#1e2227",
    "error.border": "#a03237",
    "warning.background": "#1e2227",
    "warning.border": "#89734d",
    "hint.background": "#1e2227",
    "hint.border": "#013b64"
  }
}

@MordFustang21 MordFustang21 merged commit cd2d1c2 into MordFustang21:main Aug 4, 2024
@Suhaybu Suhaybu deleted the patch-1 branch August 5, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants