This repository has been archived by the owner on Aug 5, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
MoreiraJorge
approved these changes
Jan 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Approved!
MIGMLG
added a commit
that referenced
this pull request
Jan 31, 2020
* Implemented LoadMap (#6) * Add JsonSimple to Gradle * Json Pulgin Update * Maps Dir * Implement loadMap * Tests for loadMap * Reviewed * Surpressed pmd useless violation * Add Map and Room Definitions Prototype (#8) * Added map and room definitions prototype * Changed room and map names, and added Lists * Added exceptions to ArrayList and added hasGHost * Added exceptions and cleaned up * Added hasGhost tests * Fix * Merge Added Comments to Develop Branch (#10) * Added map and room definitions prototype * Changed room and map names, and added Lists * Added exceptions to ArrayList and added hasGHost * Added exceptions and cleaned up * Added hasGhost tests * Add comments on classes Menu, and test classes * Fix v2 * Make ArrayList abstract * Add orderedList * Add BinaryTree Package * Add Package Queues * Add Stack Package * Add PriorityQueue Package * Add Graph Package * Add Network Package * Fix in Imports * Change PMD Rules * Review structures and add some comments * Fix app * Load Map Structure (#13) * Change names of method to make it more clear * Fix in Constructor of Map * Missing Files for change of name in method * Remove Debugging Prints * Done with loadMapFile * First Test for isMapLoaded Method * Done with tests for isMapLoaded * Changes to Map Structure * Fix missing commit * V1.0 of Map * V1.0 of Room * Fix problem in Testing * Add MapExceptions * Add MenuExceptions * V1.0 of Menu * Refactor Change * Fix in comments * Add List of Connections * Add numberOfDoors Method * Link Between Map and Room * Refactored Map and Room Class * Add tests Co-authored-by: Jorge Moreira <32751407+MoreiraJorge@users.noreply.github.com> * Add Game definitions * Fix comment on Generated class * Print Map (#16) * Add PrintMap * Add JavaDoc to new methods * Add Player Class (#19) * Player fix * Simulation Mode Done (#21) * Add Variable points to game * Add Exceptions to Game Interface * Final Version of Simulation Mode * Change toString and PrintMap Methods * Add Comments * Add Main Menu (#22) * Re-merge Game Menu (#24) * Add main menu * Fix menu * Fix menu with simulation * Add comments to HauntedHouse package * Add While Loops to Menus (#25) * Fix build.gradle * Fix in Simulation * Manual mode (#28) * Fix in comments * ManualGame Constructor Done * Access to player points variable * First version of Manual Mode working on Menu * Version 1.0 of Manual Game Mode * Version 1.0 of the Definition of Player * Change in printMap * Change in Menu for Manual Game Mode * Add Exceptions to Game Interface * Add Exceptions to App * Fix comment * Ratings (#29) * Add menu and ratings * Fix menus comments and exceptions * Fix manual * Add addResult and remove list getter * Add ratings to manual * Fix for when player loses all points * Fix * Release Preparation Branch (#32) * Fix (#31) * Fix in End Game * Fix comments in menu * CleanUp of Menu * Rename to MapFilesExceptions * CleanUp in difficulty * Remove Enum from jacocoReport * Interface Game CleanUP * CleanUP Manual Mode * Identation done on MapExceptions * CleanUP on Map * CleanUP on Player * CleanUP on Simulation * Comments for MapFile * Added Tests for getRoomFromName method * Ignore Menu from Tests * Remove Game Modes from tests * Tests for Results * CleanUP in Ratings * Test for Player * Fix in Menu * Forgot to add Private prefix * Investigation ongoing * Leave it like this * Fix XD * Reverse write ratings and edit menu * Fix in Map Co-authored-by: DevMig <nerdxontheline@outlook.com>
MIGMLG
added a commit
that referenced
this pull request
Jan 31, 2020
* Implemented LoadMap (#6) * Add JsonSimple to Gradle * Json Pulgin Update * Maps Dir * Implement loadMap * Tests for loadMap * Reviewed * Surpressed pmd useless violation * Add Map and Room Definitions Prototype (#8) * Added map and room definitions prototype * Changed room and map names, and added Lists * Added exceptions to ArrayList and added hasGHost * Added exceptions and cleaned up * Added hasGhost tests * Fix * Merge Added Comments to Develop Branch (#10) * Added map and room definitions prototype * Changed room and map names, and added Lists * Added exceptions to ArrayList and added hasGHost * Added exceptions and cleaned up * Added hasGhost tests * Add comments on classes Menu, and test classes * Fix v2 * Make ArrayList abstract * Add orderedList * Add BinaryTree Package * Add Package Queues * Add Stack Package * Add PriorityQueue Package * Add Graph Package * Add Network Package * Fix in Imports * Change PMD Rules * Review structures and add some comments * Fix app * Load Map Structure (#13) * Change names of method to make it more clear * Fix in Constructor of Map * Missing Files for change of name in method * Remove Debugging Prints * Done with loadMapFile * First Test for isMapLoaded Method * Done with tests for isMapLoaded * Changes to Map Structure * Fix missing commit * V1.0 of Map * V1.0 of Room * Fix problem in Testing * Add MapExceptions * Add MenuExceptions * V1.0 of Menu * Refactor Change * Fix in comments * Add List of Connections * Add numberOfDoors Method * Link Between Map and Room * Refactored Map and Room Class * Add tests Co-authored-by: Jorge Moreira <32751407+MoreiraJorge@users.noreply.github.com> * Add Game definitions * Fix comment on Generated class * Print Map (#16) * Add PrintMap * Add JavaDoc to new methods * Add Player Class (#19) * Player fix * Simulation Mode Done (#21) * Add Variable points to game * Add Exceptions to Game Interface * Final Version of Simulation Mode * Change toString and PrintMap Methods * Add Comments * Add Main Menu (#22) * Re-merge Game Menu (#24) * Add main menu * Fix menu * Fix menu with simulation * Add comments to HauntedHouse package * Add While Loops to Menus (#25) * Fix build.gradle * Fix in Simulation * Manual mode (#28) * Fix in comments * ManualGame Constructor Done * Access to player points variable * First version of Manual Mode working on Menu * Version 1.0 of Manual Game Mode * Version 1.0 of the Definition of Player * Change in printMap * Change in Menu for Manual Game Mode * Add Exceptions to Game Interface * Add Exceptions to App * Fix comment * Ratings (#29) * Add menu and ratings * Fix menus comments and exceptions * Fix manual * Add addResult and remove list getter * Add ratings to manual * Fix for when player loses all points * Fix * Release Preparation Branch (#32) * Fix (#31) * Fix in End Game * Fix comments in menu * CleanUp of Menu * Rename to MapFilesExceptions * CleanUp in difficulty * Remove Enum from jacocoReport * Interface Game CleanUP * CleanUP Manual Mode * Identation done on MapExceptions * CleanUP on Map * CleanUP on Player * CleanUP on Simulation * Comments for MapFile * Added Tests for getRoomFromName method * Ignore Menu from Tests * Remove Game Modes from tests * Tests for Results * CleanUP in Ratings * Test for Player * Fix in Menu * Forgot to add Private prefix * Investigation ongoing * Leave it like this * Fix XD * Reverse write ratings and edit menu * Fix in Map Co-authored-by: DevMig <nerdxontheline@outlook.com>
MIGMLG
added a commit
that referenced
this pull request
Feb 1, 2020
* Implemented LoadMap (#6) * Add JsonSimple to Gradle * Json Pulgin Update * Maps Dir * Implement loadMap * Tests for loadMap * Reviewed * Surpressed pmd useless violation * Add Map and Room Definitions Prototype (#8) * Added map and room definitions prototype * Changed room and map names, and added Lists * Added exceptions to ArrayList and added hasGHost * Added exceptions and cleaned up * Added hasGhost tests * Fix * Merge Added Comments to Develop Branch (#10) * Added map and room definitions prototype * Changed room and map names, and added Lists * Added exceptions to ArrayList and added hasGHost * Added exceptions and cleaned up * Added hasGhost tests * Add comments on classes Menu, and test classes * Fix v2 * Make ArrayList abstract * Add orderedList * Add BinaryTree Package * Add Package Queues * Add Stack Package * Add PriorityQueue Package * Add Graph Package * Add Network Package * Fix in Imports * Change PMD Rules * Review structures and add some comments * Fix app * Load Map Structure (#13) * Change names of method to make it more clear * Fix in Constructor of Map * Missing Files for change of name in method * Remove Debugging Prints * Done with loadMapFile * First Test for isMapLoaded Method * Done with tests for isMapLoaded * Changes to Map Structure * Fix missing commit * V1.0 of Map * V1.0 of Room * Fix problem in Testing * Add MapExceptions * Add MenuExceptions * V1.0 of Menu * Refactor Change * Fix in comments * Add List of Connections * Add numberOfDoors Method * Link Between Map and Room * Refactored Map and Room Class * Add tests Co-authored-by: Jorge Moreira <32751407+MoreiraJorge@users.noreply.github.com> * Add Game definitions * Fix comment on Generated class * Print Map (#16) * Add PrintMap * Add JavaDoc to new methods * Add Player Class (#19) * Player fix * Simulation Mode Done (#21) * Add Variable points to game * Add Exceptions to Game Interface * Final Version of Simulation Mode * Change toString and PrintMap Methods * Add Comments * Add Main Menu (#22) * Re-merge Game Menu (#24) * Add main menu * Fix menu * Fix menu with simulation * Add comments to HauntedHouse package * Add While Loops to Menus (#25) * Fix build.gradle * Fix in Simulation * Manual mode (#28) * Fix in comments * ManualGame Constructor Done * Acess to player points variable * First version of Manual Mode working on Menu * Version 1.0 of Manual Game Mode * Version 1.0 of the Definition of Player * Change in printMap * Change in Menu for Manual Game Mode * Add Exceptions to Game Interface * Add Exceptions to App * Fix comment * Ratings (#29) * Add menu and ratings * Fix menus comments and exceptions * Fix manual * Add addResult and remove list getter * Add ratings to manual * Fix for when player loses all points * Fix * HauntedHouse V1.0 (#32) * Fix (#31) * Fix in End Game * Fix comments in menu * CleanUp of Menu * Rename to MapFilesExceptions * CleanUp in difficulty * Remove Enum from jacocoReport * Interface Game CleanUP * CleanUP Manual Mode * Identation done on MapExceptions * CleanUP on Map * CleanUP on Player * CleanUP on Simulation * Comments for MapFile * Added Tests for getRoomFromName method * Ignore Menu from Tests * Remove Game Modes from tests * Tests for Results * CleanUP in Ratings * Test for Player * Fix in Menu * Forgot to add Private prefix * Investigation ongoing * Leave it like this * Fix XD * Reverse write ratings and editd menu * Fix in Map * Add FlashBack to Manual Game Mode * Fix in Menu * Commands to clean console * Add Player Exceptions * Menu V2.0 * Simulation V2.0 * Manual V2.0 * Ignore ConsoleCommands for Testing * Ignore PlayerExceptions from Tests * Add Tests for useFlashBack Method * Fix in Player * Add comments to useFlashbackTests * Add option to see flashbacks * Add javadoc to source and tests and modify build.gradle Co-authored-by: Jorge Moreira <32751407+MoreiraJorge@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : #30