Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded Math support and associative fixes. #6

Merged
merged 22 commits into from
Mar 8, 2019
Merged

Expanded Math support and associative fixes. #6

merged 22 commits into from
Mar 8, 2019

Conversation

mrfigg
Copy link
Contributor

@mrfigg mrfigg commented Mar 7, 2019

CHANGES
  1. Added exponent operator to Operation expression lib/Operation.js
  2. Added modulo operator to Operation expression lib/Operation.js
  3. Added Roll expression right-associativity grammer/dice.pegjs
  4. Added Factorial expression lib/Factorial.js
  5. Added Parentheses expression lib/Parentheses.js
  6. Added Number expression supporting negative numbers in acceptable scenarios grammer/dice.pegjs
  7. Fixed Operation expression side-associativity grammer/dice.pegjs
  8. Fixed Roll expression should store empty dice count that still evaluates to 1 for accurate render/recreation lib/Roll.js
  9. Fixed Repeat expression should not allow float count, only positive integers grammer/dice.pegjs
  10. Fixed Function expression with an empty argument list should not store an argument array containing a single value of null grammer/dice.pegjs
  11. Fixed Number expression should always wrap number values for uniform layout grammer/dice.pegjs, lib/Repeat.js, & lib/Roll.js
  12. Moved Operation expression type variable declorations to Operation expression file and cleaned up peg file to make it more ledgable lib/Operation.js & grammer/dice.pegjs
  13. Renamed right variable in the Repeat expression to content as it is a more accurate descriptor (because there is no left counterpart) and matchs the layout for Factorial and Parentheses lib/Repeat.js
  14. Added Factorial tests to match change 4 tests/Factorial.spec.js
  15. Added Parentheses tests to match change 5 tests/Parentheses.spec.js
  16. Updated Function tests to match change 10 & 11 tests/Function.spec.js
  17. Updated parser tests to match changes 1 - 11 tests/parser.spec.js
  18. Updated Repeat tests to match changes 11 & 13 tests/Repeat.spec.js
  19. Updated Roll tests to match changes 8 & 11 tests/Roll.spec.js
  20. Altered tests/test.html to give more output
  21. Generated lib/parser.js
  22. Updated version to 2.0.0-rc.3

@mrfigg mrfigg marked this pull request as ready for review March 7, 2019 19:06
@Morgul
Copy link
Owner

Morgul commented Mar 7, 2019

This pull request introduces 1 alert when merging 2013df7 into 53f000b - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

Comment posted by LGTM.com

@mrfigg
Copy link
Contributor Author

mrfigg commented Mar 7, 2019

It was a random bit of the old Roll.render method I missed. Removed.

@Morgul
Copy link
Owner

Morgul commented Mar 7, 2019

So, I just skimmed through the changes, and they look really good! I want to take some time to go through this a little bit more before merging it in.

The one change I would like is not a bump the version. It (slightly) messes with my release method, and I also want to include a few minor changes outside of this in rc.3.

@Morgul Morgul changed the title 2.0.0-rc.3 Expanded Math support and associative fixes. Mar 7, 2019
Copy link
Owner

@Morgul Morgul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look like a big improvement. Thanks!

@Morgul Morgul merged commit 6e6851d into Morgul:master Mar 8, 2019
@mrfigg
Copy link
Contributor Author

mrfigg commented Mar 8, 2019

Welcome. Glad to be of help.

@Morgul
Copy link
Owner

Morgul commented Mar 9, 2019

I've just published these changes as part of v2.0.0-rc.3.

@mrfigg
Copy link
Contributor Author

mrfigg commented Mar 9, 2019

Nice! Thanks for the quick turn around, and for the shoutout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants