-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expanded Math support and associative fixes. #6
Conversation
This pull request introduces 1 alert when merging 2013df7 into 53f000b - view on LGTM.com new alerts:
Comment posted by LGTM.com |
It was a random bit of the old |
So, I just skimmed through the changes, and they look really good! I want to take some time to go through this a little bit more before merging it in. The one change I would like is not a bump the version. It (slightly) messes with my release method, and I also want to include a few minor changes outside of this in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look like a big improvement. Thanks!
Welcome. Glad to be of help. |
I've just published these changes as part of |
Nice! Thanks for the quick turn around, and for the shoutout. |
CHANGES
exponent
operator toOperation
expression lib/Operation.jsmodulo
operator toOperation
expression lib/Operation.jsRoll
expression right-associativity grammer/dice.pegjsFactorial
expression lib/Factorial.jsParentheses
expression lib/Parentheses.jsNumber
expression supporting negative numbers in acceptable scenarios grammer/dice.pegjsOperation
expression side-associativity grammer/dice.pegjsRoll
expression should store empty dice count that still evaluates to 1 for accurate render/recreation lib/Roll.jsRepeat
expression should not allow float count, only positive integers grammer/dice.pegjsFunction
expression with an empty argument list should not store an argument array containing a single value of null grammer/dice.pegjsNumber
expression should always wrap number values for uniform layout grammer/dice.pegjs, lib/Repeat.js, & lib/Roll.jsOperation
expressiontype
variable declorations toOperation
expression file and cleaned up peg file to make it more ledgable lib/Operation.js & grammer/dice.pegjsright
variable in theRepeat
expression tocontent
as it is a more accurate descriptor (because there is noleft
counterpart) and matchs the layout forFactorial
andParentheses
lib/Repeat.jsFactorial
tests to match change 4 tests/Factorial.spec.jsParentheses
tests to match change 5 tests/Parentheses.spec.jsFunction
tests to match change 10 & 11 tests/Function.spec.jsparser
tests to match changes 1 - 11 tests/parser.spec.jsRepeat
tests to match changes 11 & 13 tests/Repeat.spec.jsRoll
tests to match changes 8 & 11 tests/Roll.spec.jsUpdatedversion
to2.0.0-rc.3