Release 1.15.0 #216
Merged
Release 1.15.0 #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In response to GitHub's brown-out of the platform.
Dive greedily in left nodes when possible. The new algorithm does not need to track whether we come from a parent or a child to decide what to do next.
It mostly changes package_info to use the new way of specifying CMake properties.
Change generate_sorting_network.py to automatically find the best sorting network from the SorterHunter directory for a given size, and generate the corresponding code for sorting_network_sorter.
Also smaller depth for the 28-input network. Once again courtesy of SorterHunter.
- Make sorting_network_sorter<3> stable - Mark sorter_traits<N> specializations as stable for N in [0,3]
The new abstraction is simpler, more to the point, and just as useful in the library. Moreover it allows to get rid of a bunch of speciail cases I never liked. The precondition check in the constructor is just the cherry on top.
The only reason verge_adapter, unlike verge_sorter, did not work with bidirectional iterators was the half-baked hacks using sized_iterator which I couldn't reasonably impose on users, and I certainly did not want to add more hacks to more sorters. Replacing size_iterator with sized_range solved that issue. This change includes a minr refactor to reuse a bit of split_adapter to compute the iterator category of verge_adapter, which is done the same way.
The first bug is due calling hybrid_adapter::get with two template parameters in the constructor while it only accepts one. The second bug is because stable_adapter<hybrid_adapter<A, B>>::type is not constructible from hybrid_adapter<A, B>. These two bugs mean that the specialization probably never worked. A simple test case was added, which would have exposed both bugs.
Once again thanks to the SorterHunter project by @bertdobbelaere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.