xhtml compatibility #727
Closed
xhtml compatibility #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @DawidSu! Thanks for your contribution! I totally forgot about xhtml! |
Mottie
reviewed
Mar 1, 2019
| .appendTo(base.temp[0]); | ||
| }catch(e){ | ||
| console.log(data.html); | ||
| } |
There was a problem hiding this comment.
Why did this need to be wrapped in a try catch function?
There was a problem hiding this comment.
Sorry its not necessary. it was a help to fin out why the keyboard don't work
Mottie
added a commit
that referenced
this pull request
Mar 9, 2019
|
I fixed this in 5cfc7f8. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xhtml use lower case