-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Since last update, header inputs no longer accessible... #911
Comments
Hi @Francks11! It's because of this line: // needed or jQuery v1.2.6 throws an error
e.preventDefault(); I'm not sure why, but if I comment out that prevent default, jQuery v1.2.6 will throw an "Uncaught TypeError: handler.apply is not a function". Maybe it's time to drop support for 1.2.6? |
Hi @Mottie, I use currently version v1.7.2 of jQuery... Thanks |
Yes, but tablesorter supports jQuery v1.2.6, so I need to find a work around or remove support for that really old version. |
jQuery 1.2.6 is out May 24, 2008. 7 years... Indeed, it is time to drop support if that is not possible otherwise. :-p |
Does that table even sort?... if I right-click in the input, I can get focus to it, and yes, I know that isn't ideal. |
For this case, I do not use sorting because the data must appear in a specific order. But I use scroller widget for fixed header and fixed columns... Its not very practical with the right click :-) |
Why have you the need to add this code e.preventDefault(); from this version? |
Umm, because there was an error in jQuery v1.2.6? It should work now... the update is in the master branch. |
Here is your demo using the core from the master branch. |
okay thanks for your reactivity. :-) |
I encounter a other issue with header input fields... It is no longer possible to select the text in the field with mouse with Internet Explorer, for example, to replace text. |
Set the |
Thanks :-), a lot of options unknow. |
I suggest you a improvement of cancelSelection, do not apply on input in header columns. Use case : I don't want that the header text can be select, but I would like that the text can be select on input. I have see this code in tablesorter, which cancel select :
Thanks. :-) |
The cancel selection is applied to the header cell, not the inputs. Since you have a extra rows in the header that are not used for sorting, you can use the same method the filter widget uses by adding "tablesorter-ignoreRow" (set by <tr class="tablesorter-ignoreRow">
...
</tr> I'll update the docs to emphasize this fact. |
Thanks :-) |
Hello @Mottie,
since last update, header inputs are no longer accessible.
You can see this here : http://jsfiddle.net/Francks11/oqfq47fc/1/
Why?
Thanks
The text was updated successfully, but these errors were encountered: