Fixed updateCell to work correctly with child rows #1381
Conversation
|
Hi @andysleigh! Thanks for catching this problem and providing a fix! |
js/jquery.tablesorter.js
Outdated
| @@ -1328,6 +1328,11 @@ | |||
| cache[ c.columns ].raw[ icell ] = tmp; | |||
| tmp = ts.getParsedText( c, cell, icell, tmp ); | |||
| cache[ icell ] = tmp; // parsed | |||
| var tmpRow = cache[c.columns].$row; | |||
| if (tmpRow.length == 2) { | |||
There was a problem hiding this comment.
Please change this to if (tmpRow.length > 1) { as it is possible to have more than one child row.
|
Oh and please don't include the |
js/jquery.tablesorter.js
Outdated
| var tmpRow = cache[c.columns].$row; | ||
| if (tmpRow.length == 2) { | ||
| // reapply child row | ||
| $row = $row.add(tmpRow[1]); |
There was a problem hiding this comment.
And as above, more than one child row is possible - $row = $row.add(tmpRow);
That "should" work, but I haven't tested it... you should be able to add all the rows back; jQuery will prevent duplication.
cache[ c.columns ].$row doesnt need to be updated in updateCell.
|
Oh, I was thinking there was more to be done for this PR... so essentially only two changes were made:
Is that correct? |
|
Yes this seems to be all it needed. The first change sorts out the indexing so we get the correct row from the cache. The second part, following on from my original change I realised there's no need to update cache[...].$row at all in this method so I removed it. Sorting now works correctly after calling updateCell and the child row remains linked to the parent row. |
|
Ok great, thanks again so much for your help! |
The updateCell method currently fails on tables with child rows. This is because when it gets the index of the row it is searching all rows (including child rows). The resulting index is therefore not the correct index to be using against the cache. Also when the update row is inserted into the cache it no longer has the child row linked to it.
The fix therefore has two parts. The first is to filter the list of rows to exclude child rows when finding the row index. The second part is to ensure the child row is linked to the updated row before inserting it to the cache.