Video download *half* fix #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No F#cking way Scrap this PR and scrap this project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have fixed the issue that the that videos won't be downloaded.
But due to the new limitations of Fansly and Chrome there are some things to keep in mind
Chrome extensions cannot use SharedArrayBuffer (bug in chrome), so ffmpeg.wasm can't be used to merge the video and audio files before download.
Which is why video and audio files need to be downloaded separately.
Also, videos behind a paywall (the videos which you can preview to be exact) cannot be downloaded since it's a
.m3u8file with video chunks.And due to there being no connection between the post which you want to download and the download URL
The script is kind of doing a guessing game by grabbing the last added
.mpdfile in the array (which does not always correspond to the correct video).Honestly @Motyldrogi, if you wish to keep this project alive I highly recommend creating a desktop app instead, since you are able to use FFmpeg then.