Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚑 修正明日方舟游戏信息的模板与图片渲染 #306

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

GuGuMur
Copy link
Contributor

@GuGuMur GuGuMur commented Jul 27, 2023

丢人了(捂脸)

@netlify
Copy link

netlify bot commented Jul 27, 2023

Deploy Preview for nonebot-bison ready!

Name Link
🔨 Latest commit 254cbe5
🔍 Latest deploy log https://app.netlify.com/sites/nonebot-bison/deploys/64c8d5f13a775b000837acee
😎 Deploy Preview https://deploy-preview-306--nonebot-bison.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 93.33% and project coverage change: +0.13% 🎉

Comparison is base (fb8c93c) 81.72% compared to head (254cbe5) 81.85%.
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
+ Coverage   81.72%   81.85%   +0.13%     
==========================================
  Files          63       63              
  Lines        3157     3158       +1     
==========================================
+ Hits         2580     2585       +5     
+ Misses        577      573       -4     
Flag Coverage Δ
smoke-test 81.85% <93.33%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
nonebot_bison/platform/arknights.py 85.00% <93.33%> (+2.98%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AzideCupric
Copy link
Collaborator

从6400改到100不会出事吗

@GuGuMur
Copy link
Contributor Author

GuGuMur commented Jul 28, 2023

从6400改到100不会出事吗

点击展开折叠长图

试了以下,调成100后这个效果应该还算正常

@felinae98 felinae98 added the bug Something isn't working label Jul 28, 2023
if "content" in raw_data:
if raw_data["bannerImageUrl"]:
pics.append(raw_post["bannerImageUrl"])

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

先判断bannerImageUrl是为什么

而且raw_data存在content字段时也会存在bannerImageUrl字段?(按你现在写的
那岂不是永远不会到第二个分支(?

@felinae98 felinae98 merged commit 7d7c71d into MountainDash:main Aug 9, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants