Skip to content

Commit

Permalink
Fix determining w3c for browserstack (webdriverio#3936)
Browse files Browse the repository at this point in the history
* feat: add RDC API to service

- update test

* fix: support proper W3C for BrowserStack

This PR fixes webdriverio#3935
  • Loading branch information
wswebcreation authored and christian-bromann committed May 7, 2019
1 parent b0d7aa6 commit 5f011c4
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions packages/webdriver/src/utils.js
Expand Up @@ -210,10 +210,10 @@ export function isW3C (capabilities) {
capabilities.platformName &&
capabilities.browserVersion &&
/**
* local safari doesn't provide platformVersion therefor
* check also for setWindowRect
* local safari and BrowserStack don't provide platformVersion therefor
* check also if setWindowRect is provided
*/
(capabilities.platformVersion || capabilities.setWindowRect)
(capabilities.platformVersion || capabilities.hasOwnProperty('setWindowRect'))
)
return Boolean(hasW3CCaps || isAppium)
}
Expand Down

0 comments on commit 5f011c4

Please sign in to comment.