Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix determining w3c for browserstack #3936

Merged
merged 11 commits into from May 7, 2019
Merged

Conversation

wswebcreation
Copy link
Member

Proposed changes

This PR fixes #3935

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

The check is already covered by this for Safari

        it('isW3C', () => {
            const requestedCapabilities = { w3cCaps: { alwaysMatch: {} } }
            expect(environmentDetector({ capabilities: appiumCaps, requestedCapabilities }).isW3C).toBe(true)
            expect(environmentDetector({ capabilities: chromeCaps, requestedCapabilities }).isW3C).toBe(false)
            expect(environmentDetector({ capabilities: geckoCaps, requestedCapabilities }).isW3C).toBe(true)
            expect(environmentDetector({ capabilities: safariCaps, requestedCapabilities }).isW3C).toBe(true)
            expect(environmentDetector({ capabilities: edgeCaps, requestedCapabilities }).isW3C).toBe(true)
            expect(environmentDetector({ capabilities: safariLegacyCaps, requestedCapabilities }).isW3C).toBe(false)
            expect(isW3C()).toBe(false)
        })

Reviewers:

@webdriverio/technical-committee

@codecov
Copy link

codecov bot commented May 7, 2019

Codecov Report

Merging #3936 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3936   +/-   ##
=======================================
  Coverage   98.54%   98.54%           
=======================================
  Files         153      153           
  Lines        3448     3448           
  Branches      752      752           
=======================================
  Hits         3398     3398           
  Misses         45       45           
  Partials        5        5
Impacted Files Coverage Δ
packages/webdriver/src/utils.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e839716...b913568. Read the comment docs.

Copy link
Contributor

@CrispusDH CrispusDH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we check response for non w3c?

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@christian-bromann
Copy link
Member

could we check response for non w3c?

@CrispusDH what do you mean?

@CrispusDH
Copy link
Contributor

never mind, I just think how we know exactly that this property does not exist in now w3c

@christian-bromann christian-bromann added the PR: Spec Compliancy 👓 PRs that contain changes to the protocol specs label May 7, 2019
@christian-bromann christian-bromann merged commit f6f0816 into master May 7, 2019
@christian-bromann christian-bromann deleted the fix/w3c-browserstack branch May 7, 2019 08:34
yamkay pushed a commit to MoveInc/webdriverio that referenced this pull request Sep 4, 2019
* feat: add RDC API to service

- update test

* fix: support proper W3C for BrowserStack

This PR fixes webdriverio#3935
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Spec Compliancy 👓 PRs that contain changes to the protocol specs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isW3C can't be determined for Browserstack responce
3 participants