New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix determining w3c for browserstack #3936
Conversation
- update test
This PR fixes #3935
Codecov Report
@@ Coverage Diff @@
## master #3936 +/- ##
=======================================
Coverage 98.54% 98.54%
=======================================
Files 153 153
Lines 3448 3448
Branches 752 752
=======================================
Hits 3398 3398
Misses 45 45
Partials 5 5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we check response for non w3c?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@CrispusDH what do you mean? |
never mind, I just think how we know exactly that this property does not exist in now w3c |
* feat: add RDC API to service - update test * fix: support proper W3C for BrowserStack This PR fixes webdriverio#3935
Proposed changes
This PR fixes #3935
Types of changes
Checklist
Further comments
The check is already covered by this for Safari
Reviewers:
@webdriverio/technical-committee