Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isW3C can't be determined for Browserstack responce #3935

Closed
wswebcreation opened this issue May 7, 2019 · 1 comment · Fixed by #3936
Closed

isW3C can't be determined for Browserstack responce #3935

wswebcreation opened this issue May 7, 2019 · 1 comment · Fixed by #3936
Labels

Comments

@wswebcreation
Copy link
Member

wswebcreation commented May 7, 2019

Environment (please complete the following information):

  • WebdriverIO version: latest
  • Mode: Testrunner
  • If WDIO Testrunner, running sync/async: both
  • Node.js version: -
  • NPM version: -
  • Browser name and version: Edge
  • Platform name and version: Windows
  • Additional wdio packages used (if applicable): @wdio/webdriver

Config of WebdriverIO

    capabilities: [{
        'bstack:options': {
            'os': 'Windows',
            'osVersion': '10',
            'local': 'false',
            'seleniumVersion': '3.14.0'           
        },
        'browserName': 'Edge',
        'browserVersion': '18.0',
    }],

Describe the bug
Browserstack is not providing the right capabilities to determine if the instance is a W3C instance. The response contains the following data

const response = {
    'acceptInsecureCerts': false,
    'browserName': 'MicrosoftEdge',
    'browserVersion': '44.17763.1.0',
    'pageLoadStrategy': 'normal',
    'platformName': 'windows',
    'setWindowRect': false,
    'timeouts': { 'implicit': 0, 'pageLoad': 300000, 'script': 30000 },
    'proxy': {},
    'webdriver.remote.sessionid': '993e34c09b8e0d9317347980ab4e186ddc6c06b2'
}

We don't get back a platformVersion and the setWindowRect is false meaning BrowserStack will never be seen as a W3C instance, see also

https://github.com/webdriverio/webdriverio/blob/master/packages/webdriver/src/utils.js#L193

To Reproduce

Expected behavior
Or BrowserStack needs to fix this, or WebdriverIO needs to come with a patch

Log
see above

@christian-bromann
Copy link
Member

The fix for this should be in https://github.com/webdriverio/webdriverio/blob/master/packages/webdriver/src/utils.js#L216 by changing it to:

Object.keys(capabilities).includes('setWindowRect')

wswebcreation added a commit that referenced this issue May 7, 2019
christian-bromann pushed a commit that referenced this issue May 7, 2019
* feat: add RDC API to service

- update test

* fix: support proper W3C for BrowserStack

This PR fixes #3935
yamkay pushed a commit to MoveInc/webdriverio that referenced this issue Sep 4, 2019
* feat: add RDC API to service

- update test

* fix: support proper W3C for BrowserStack

This PR fixes webdriverio#3935
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants