Game log files for server play lack a world name component

[Cervator]

If you play a local game the log file for game/world stuff will be named something like Terasology-world1.log

If you join a server you'll get Terasology-.log - we probably should give that some alternative name (could just use a placeholder "world" unless we have a local world with a name)

Should be easy.

[msteiger]

Maybe we could use the seed string?

[Cervator]

Are clients actually sent that? I thought sharing the seed could potentially be a cheating issue. It could also be long or controversial if players use creative seed values ;-)

Could we use the server name / address in some fashion? With a sequence number at the end if a user repeatedly joins the same server in one session.

[papeixoto]

@Cervator @msteiger Hi. I'm also a student from Porto, we are a lot i know :). For this deliverable we're supposed to implement a feature and document it. So, in order to start, my group would greatly appreciate some explanation about the packages/modules related with this feature and the the main steps to implement it.

[Cervator]

You're all most definitely welcome, the more the merrier! :-)

This one should be pretty easy. It is an engine / config feature, no (game) modules involved. Although, I'm realizing our logback.xml (in Terasology/facades/PC/src/main/resources) is referring to a ${phase} I have no idea where it is getting from :D @msteiger probably knows.

In this kind of case CTRL-SHIFT-F is your best friend in IntelliJ. Search for a related keyword, like "phase" and see what hits you get. Likely you can deduce which is the relevant one then see if that brings you to the code we need tweaked, or if you'll find a new keyword to go for.

Find Usages on method names or even simply CTRL-left mouse to navigate between things also helps a lot :-)

[msteiger]

The phase and the other parts of the log filename are configured in LoggingContext.

I assume you can get the game name from the GameManifest. If that does not work you might want to check this spot here: JoinServer L84. This is where the client get the game name from the server.

[arkka]

@Cervator @msteiger Hi, based on your comments I try to solve this issue with my solution branch fix-log-files-on-server-play. As @msteiger mentioned before, I made the implementation on JoinServer class.

In order to get the remote host address, I need to create new methods on ServerImpl class L138 . Is this the most effective way to achieve this?