UITreeView (& test method conventions) #2338
Conversation
rzats
added
Topic: Architecture
|
Hooray Jenkins reported success with all tests good! |
|
Hooray Jenkins reported success with all tests good! |
|
Hooray Jenkins reported success with all tests good! |
|
Hooray Jenkins reported success with all tests good! |
|
Hooray Jenkins reported success with all tests good! |
| * @return The index of the specified {@code Tree}. | ||
| */ | ||
| public int getIndex(Tree<T> node) { | ||
| if (node == null) { |
There was a problem hiding this comment.
You can use Preconditions.checkArgument() here, if you like.
There was a problem hiding this comment.
Just noticed the notification for this comment. Fixed all the checks accordingly.
|
I looked over it briefly and didn't test all corner cases, but afaict, it looks good. Slightly offtopic: The behavior node editor currently uses |
|
@msteiger: thanks for the test! I've actually checked the BTE package before starting work on this PR - it's specifically meant for tree visualizations as opposed to tree views, so not a great fit. |
|
That's what I expected. Thanks for the clarification. |
|
Hooray Jenkins reported success with all tests good! |
|
@rzats got a IndexOutOfBoundException while testing it: |
|
The crash happens when you minimize a node near the end of the list while a child node is still selected. When it isn't near the end of the list, another item gets selected (which is also strange). |
|
Great work otherwise, the PR can be merged once the bug is fixed. |
|
Merged, thanks for the PR |
|
Hooray Jenkins reported success with all tests good! |
Contains
Treedata structure that contains the widget's elements and aTreeModelhelper class.TreeViewTestScreen- fairly self-explanatory 😜testMethodNameas opposed tomethodName- this is a mostly unrelated change as suggested in a Slack discussion.This PR was previously located in my Terasology fork. In retrospect, this wasn't a great idea: local PRs have no @GooeyHub testing, no mergeability checks with the upstream repository and little to none community exposure: IMO, going for a base repository fork is a better idea for subsequent deliverables.
How to test
showScreen treeViewTestScreenin the in-game console. Make sure you do so manually without using autocompletion - otherwise showScreen() autocompletion breaks screen initialization #2329 triggers, causing initialization issues.Controls