Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NUI editor: additional settings and finishing touches #2438

Merged
merged 10 commits into from
Aug 20, 2016
Merged

NUI editor: additional settings and finishing touches #2438

merged 10 commits into from
Aug 20, 2016

Conversation

rzats
Copy link
Member

@rzats rzats commented Aug 13, 2016

Contains

Various improvements to the NUI screen/skin editors; see rzats/gsoc-nui-editor#10, rzats/gsoc-nui-editor#13 and rzats/gsoc-nui-editor#14.

  • Added a 'Preview screen locale' setting - this will change the language of the editor's preview widget (but not the NUI editor or the game itself). Useful for reviewing things such as long UI strings that may break interface rendering!
  • Added a "Close" button to the editors (as an alternative to ESC & F10/F11) and a "Delete" option to tree view node context menues (as an alternative to DELETE).

How to test

Press F10/F11 in the main menu to run the NUI screen/skin editors, then verify that all of the above work as intended 😄

Outstanding before merging

  • Implement the features from Further tree view / screen view binding rzats/gsoc-nui-editor#13 (tree view to widget binding).
  • Review the source code's Javadoc, modify and fill stubs where appropriate.
    • Also fix Checkstyle warnings where appropriate.
  • Autosave the asset changes to a temporary JSON file, then add an option to apply the changes to the actual asset file.
  • Add a popup to warn the user that changes will be lost on asset change.
  • Automatically edit newly added attributes.
    • Automatically edit the IDs of newly added widgets.
  • A "Debug Tools" menu with options to show different dev tools (console, UI editor, skin editor, BT editor).
  • When the editor's strings are somewhat finalized, internationalize them all!

@rzats rzats added Category: Doc Requests, Issues and Changes targeting javadoc and module documentation Topic: UI/UX Requests, Issues and Changes related to screens, artwork, sound and overall user experience GSOC labels Aug 13, 2016
@rzats rzats added this to the Alpha 4 milestone Aug 13, 2016
@rzats rzats self-assigned this Aug 13, 2016
@GooeyHub
Copy link
Member

Hooray Jenkins reported success with all tests good!

@Cervator
Copy link
Member

I know there has been a good amount of chat about this one on Slack and there are still two unchecked boxes up top, but is this getting close enough where I can help any with merge testing or anything? :-)

I noticed the issue the top unchecked box leads to has already been closed as well. Feels like this one is close!

@rzats
Copy link
Member Author

rzats commented Aug 19, 2016

@Cervator: the top item is still a WIP. It's mostly a visual extra though, so at this point testing would be really appreciated 😃

@Cervator
Copy link
Member

Played around with it some :-) Probably not as thoroughly as @flo would. Works well for me!

Curious question: should something like alignments where there is a finite set of options be editable via drop-down or other selection of just the valid values? Anything that can be backed by an enum so to say. Maybe still with free-form available.

Should there be a "duplicate" option for some things? Like if you're adding a bunch of similar fields.

I realize those are more future suggestions to probably put in a list somewhere rather than actual feedback on this PR ... :D

I did manage to crash the game at one point by attempting to add a widget of type engine:Port :

com.google.gson.JsonSyntaxException: java.lang.IllegalStateException: Cannot construct 'engine:Port' - no accessible default constructor

@GooeyHub
Copy link
Member

Hooray Jenkins reported success with all tests good!

@flo flo merged commit e913a01 into MovingBlocks:develop Aug 20, 2016
@flo
Copy link
Contributor

flo commented Aug 20, 2016

With the option to save (module assets) with a single click I think we got an very important extra feature added. I merged the changes.

You checked "Autosave" above as implemented feature, but it does not seem to be implemented. Although we warn now the user about unsaved changes when he switches the asset which is good.

@rzats rzats deleted the nui-editor-preferences branch August 20, 2016 18:21
@rzats rzats mentioned this pull request Aug 21, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Doc Requests, Issues and Changes targeting javadoc and module documentation Topic: UI/UX Requests, Issues and Changes related to screens, artwork, sound and overall user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants