-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NUI editor: additional settings and finishing touches #2438
Conversation
Hooray Jenkins reported success with all tests good! |
I know there has been a good amount of chat about this one on Slack and there are still two unchecked boxes up top, but is this getting close enough where I can help any with merge testing or anything? :-) I noticed the issue the top unchecked box leads to has already been closed as well. Feels like this one is close! |
@Cervator: the top item is still a WIP. It's mostly a visual extra though, so at this point testing would be really appreciated 😃 |
Played around with it some :-) Probably not as thoroughly as @flo would. Works well for me! Curious question: should something like alignments where there is a finite set of options be editable via drop-down or other selection of just the valid values? Anything that can be backed by an enum so to say. Maybe still with free-form available. Should there be a "duplicate" option for some things? Like if you're adding a bunch of similar fields. I realize those are more future suggestions to probably put in a list somewhere rather than actual feedback on this PR ... :D I did manage to crash the game at one point by attempting to add a widget of type
|
Hooray Jenkins reported success with all tests good! |
With the option to save (module assets) with a single click I think we got an very important extra feature added. I merged the changes. You checked "Autosave" above as implemented feature, but it does not seem to be implemented. Although we warn now the user about unsaved changes when he switches the asset which is good. |
Contains
Various improvements to the NUI screen/skin editors; see rzats/gsoc-nui-editor#10, rzats/gsoc-nui-editor#13 and rzats/gsoc-nui-editor#14.
How to test
Press F10/F11 in the main menu to run the NUI screen/skin editors, then verify that all of the above work as intended 😄
Outstanding before merging