New widget "Image Slideshow"

[ar0ne]

Contains

This is new ui widget for slideshows images.

How to test

Currently, we don't have a bunch of associated images. But you could add for example "default" image.

e.g. GameDetailsScreen(line: 383).

    protected void setPreviewImage(TextureRegion texture) {
        UIImageSlideshow slider = find("preview", UIImageSlideshow.class);
        if (slider != null) {
            slider.addImage(texture);
            slider.addImage(Assets.getTexture(DEFAULT_PREVIEW_IMAGE_URI).get());
        }
    }

Outstanding before merging

Not sure but now it works automatically. Do we need to add buttons "next" and "prev" ? Or better to add new card and put it to backlog ?

[GooeyHub]

Hooray Jenkins reported success with all tests good!

[syntaxi]

A few changes

[syntaxi]

You can use the delta here instead of making calls to Date.
Since delta is the time since last call you can do something like this:

public void update(float delta) {
    imageDisplayTime += delta;
    if (imageDisplayTime >= speed) {
        imageDisplayTime = 0f;
        /* Call your image switching here */
    }
}

[ar0ne]

Great idea, thanks!

[syntaxi]

Should this line be here? Won't it result in the image being drawn twice, once in the if below and once here?

[ar0ne]

Nope. thanks!

[syntaxi]

I'm making a suggestion that instead of manually drawing the image here, you make this widget use an UIImage.

You can simply call it's draw here and use a binding to automatically update the image in it when the image index here is altered.

You can also delegate to its getPreferredContentSize.

[syntaxi]

Alternatively you can consider extending the UIImage which will also allow you to do similar and utilise it's default methods.

[GooeyHub]

Hooray Jenkins reported success with all tests good!

[Cervator]

Tests out, nice work :-) I concur with Jelly's comments, happy to merge this after those are addressed.

On Slack we discussed the possibility of a timed cycle variant vs manual back/forward. That could be done in a separate PR or along with this one, up to you.

[GooeyHub]

Uh oh, something went wrong with the build. Need to check on that

[GooeyHub]

Hooray Jenkins reported success with all tests good!