feat(JOML): migrate FirstPeronHeldItem/Mount/Transform Component #4178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 25afc9f into 449d519 - view on LGTM.com new alerts:
|
jdrueckert
approved these changes
Oct 21, 2020
engine/src/main/java/org/terasology/input/cameraTarget/PlayerTargetSystem.java
Outdated
Show resolved
Hide resolved
jdrueckert
reviewed
Oct 21, 2020
pollend
force-pushed
the
feature/joml-migrate-first-person-component
branch
from
5cc5ea7
to
6ce62f6
Compare
jdrueckert
approved these changes
Oct 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of changes for #4177 and #4162 . This migrates FirstPersonHeldItem and any classes associated with this component. This is self contained and has no impact on omega.
This mainly affects held items and targeting blocks.